-
1. Re: Checkstyle
mageshbk Dec 10, 2010 5:16 AM (in response to tcunning)Tom, I think you mismatched the rule names with the sample.
Tom Cunningham wrote:
Checkstyle rule "DesignForExtension" :
This is unnecessary and should be removed from the rules.
Tom Cunningham wrote:
Checkstyle rule "FinalLocalVariable"
This is a safety measure and I do not mind having it. As long as you have no intention of modifying the parameters, it should be final.
-
2. Re: Checkstyle
tcunning Dec 10, 2010 10:31 AM (in response to mageshbk)You're right - I have the rule names mixed up.
As for FinalLocalVariable, there's two rules that check this same area.
FinalLocalVariable : http://checkstyle.sourceforge.net/config_coding.html#FinalLocalVariable
ParameterAssignment : http://checkstyle.sourceforge.net/config_coding.html#ParameterAssignment
I think having ParameterAssignment enabled and FinalLocalVariable disabled would cover us without being so draconian. If we really want to make all parameters final, that's fine - we can leave FinalLocalVariable enabled, but I think we're already covered for safety by the ParameterAssignment rule.