I noticed some invalid usage of the logging API
[tdiesler@localhost jbosgi-framework]$ git grep "log.error(" core/src/main/java/org/jboss/osgi/framework/plugin/internal/URLHandlerPluginImpl.java: log.error("A non-compliant instance of " + URLStreamHand core/src/main/java/org/jboss/osgi/framework/plugin/internal/URLHandlerPluginImpl.java: log.error("A non-compliant instance of " + ContentHandle
This should use the
log.errorf("Error in %s", obj)
variant. Nothing to do, I fixed it.
Doh! And I remember I once stressed the benefits of using the format string as opposed to string concatenation! Thanks for the reminder