-
15. Re: Race Condition?
pgmjsd Jul 28, 2010 6:47 AM (in response to didisoft)I found SP12 in the jboss Maven repository: http://repository.jboss.org/nexus/content/groups/public/
The maven coordinates are:
GroupId: org.jboss.embeddedArtifactId: jboss-embedded-allVersion: beta3.SP12I've also found it in SVN here:http://anonsvn.jboss.org/repos/jbossas/tags/EMBEDDED_JBOSS_BETA_12/I built it sucessfully, now I just have to figure out what version of AOP it is using. I think it's 2.0.0.CR1 or something. I assume that is also somewhere in SVN. I'm going to see if the jars produced by the build are the same as the ones I am using.
Also, what did you use to de-compile it?
Also, maybe we should start another thread. I'm getting tired of scrolling past that listing of the whole source file up there.
-
16. Re: Race Condition?
didisoft Jul 28, 2010 7:21 AM (in response to pgmjsd)For decompilation I've used Cavaj.
Notify me if you create a new thread because I'm too lazy for that kind of activity:)
-
17. Re: Race Condition?
pgmjsd Jul 28, 2010 10:33 AM (in response to didisoft)Oh, CavaJ is Windoze only.
More about building from sources:
- Checked out http://anonsvn.jboss.org/repos/jbossas/tags/EMBEDDED_JBOSS_BETA3_SP12.
- Ran build/build.sh, then embedded/build.sh. The embedded jars end up in embedded/output/embedded-jboss/lib. The JBoss AOP jars are downloaded and placed in thirdparty/jboss/aop/lib during the build/build.sh step.
- The Domain class is in thirdparty/jboss/aop/libs/jboss-aop-jdk50.jar. The component-info.xml file says that this is version 2.0.0.CR1. So, I looked for that... found it here: http://anonsvn.jboss.org/repos/jbossas/projects/aop/tags/JBoss_AOP_2_0_0_CR1
- Checked out http://anonsvn.jboss.org/repos/jbossas/projects/aop/tags/JBoss_AOP_2_0_0_CR1
- Ran build/build.sh, the jars end up in aop/output/lib. jboss-aop-jdk50.jar is identical to the one produced by the embedded jboss build, and the Domain.class files are all equivalent (embedded jboss build, aop build, and the one from my own SP12 maven library).
So basically, this seems to build SP12 from sources. I'm going to try applying your patch.
-
18. Re: Race Condition?
pgmjsd Jul 28, 2010 11:21 AM (in response to didisoft)Since the patch was made for the de-compiled sources, the line numbers don't work with the real sources. What method / methods did you patch in Domain.java?
-
19. Re: Race Condition?
pgmjsd Jul 29, 2010 12:42 AM (in response to pgmjsd)I figured out where the patch goes. I only needed to rebuild JBoss AOP and replace org/jboss/aop/Domain*.class in jboss-embedded-all.jar. I haven't had a single ConcurrentModificationException yet.
-
20. Re: Race Condition?
didisoft Jul 29, 2010 3:48 AM (in response to pgmjsd)org.jboss.aop.Domain
public LinkedHashMap getBindings()I am curious why do you want to patch it in case you don't have the ConcurrentModificationException
-
21. Re: Race Condition?
pgmjsd Jul 29, 2010 5:49 PM (in response to didisoft)I figured out how to apply the patch. Since I've applied it, no ConcurrentModificationExceptions. Before the patch, our CI build would fail about 40% of the time with this exception.
-
22. Race Condition?
pgmjsd Jan 17, 2011 9:03 AM (in response to pgmjsd)I've posted instructions on how to apply the patch here. This has been working in our CI build server at work for quite a while now.