Build system, tests, docs, and model class change
perneto Feb 2, 2011 11:38 AM
On Wed, Feb 2, 2011 at 3:48 PM, Olivier Pernet <omp08@doc.ic.ac.uk> wrote:>
> Hi Gary,
>
> I've finished the first "draft" of my Scala extension, which you can
> see at http://code.google.com/p/session-scala/ if you're interested.
Thats good news - would like to take a look, its just finding the time at
the moment. However let me know your thoughts on how we could like you
project in on the scribble project website, as it would be good to capture
related projects.
> As I worked on this I was using an older working copy of Scribble,
> with the equals implementation for When which you said was breaking
> one of the tests.
>
> I'd like to fix that if possible, so that I can use the Scribble trunk
> again and make it easier for others to build my code.
> I just updated my copy and tried building Scribble, with the equals
> implementation: it seems to pass all tests now, even with the change.
> Can I commit it?
If it passes the tests then should be ok to commit. However have you used
the qa profile, as this runs more tests:
mvn clean install -Pqa
>
> I see that there's a developer guide in the sources, but I don't know
> how to compile it. Which maven target is it?
>
The docs are built in another profile, so to do a complete test and docs
build, you use:
mvn clean install -Pqa,docs
I'm having problems with the docs:
[ERROR] The project org.scribble.docs:userguide:2.0.0-SNAPSHOT (/Users/omp08/Code/scribble/docs/userguide/pom.xml) has 1 error [ERROR] Unresolveable build extension: Plugin org.jboss.maven.plugins:maven-jdocbook-plugin:2.2.3 or one of its dependencies could not be resolved: Unable to get dependency information for org.apache.xmlgraphics:xmlgraphics-commons:jar:fop-svn-r784789: Failed to retrieve POM for org.apache.xmlgraphics:xmlgraphics-commons:jar:fop-svn-r784789: Failure to resolve org/apache/xmlgraphics/xmlgraphics-commons/fop-svn-r784789/xmlgraphics-commons-fop-svn-r784789.pom from https://repository.jboss.org/nexus/content/groups/public/ was cached in the local repository. Resolution will not be reattempted until the update interval of jboss-public-repository-group has elapsed or updates are forced. Original error: Error transferring file: Connection reset org.apache.xmlgraphics:xmlgraphics-commons:pom:fop-svn-r784789 from the specified remote repositories: jboss-public-repository-group (https://repository.jboss.org/nexus/content/groups/public/, releases=true, snapshots=true), central (http://repo1.maven.org/maven2, releases=true, snapshots=false)
>
> Nobuko asked me to have a look at the projection implementation to see
> if it matches the theory. Do you have any particular things you'd like
> me to look at there?
The implementation is in bundles/org.scribble.protocol.projection - I think
it covers most use cases, but would be worth a review. Would be good to add
further test cases (in the org.scribble.protocol.ctk bundle) to outline any
scenarios not handled, and then if you have the time, extend the
implementation to handle them.