Weld leakage into ARQ subsystem

[thomas.diesler]

Folks/Stuart,

https://issues.jboss.org/browse/JBAS-8858

I see a number of commits to the ARQ subsystem that are related to Weld tests

https://github.com/jbosgi/jboss-as/tree/f7fe122705d14d6b7dc65dfb4039d366a983412b/arquillian

and history

The JMXTestRunner should be agnostic about specific test requirements. To do stuff like this ARQ offers the notion of zero to many TestEnrichers. Perhaps there is a reason why Weld specific TestEnrichers cannot be used, in which case I'd like to talk about the required functioanlity that needs to be provided by ARQ.

[alesj]

We (Stuart and me) already discussed this, and he's aware that this needs to be fixed.

I think a simple / basic idea is to have SetupActions as part of deployment's attachments,

where each sub-system properly adds them to the underlying deployment.

But I'll let you two discuss the details. :-)

[swd847]

There are two weld related things in the subsystem, both of them are temporary.

At the moment there is no 'proper' way to tell when a deployment is finished, so I wait on the weld service to come up to make sure that the deployment is in a usable state before the tests run.

Also as Ales mentioned above I am also planning on moving the setup actions stuff out of Arquillian and into the appropriate subsystem.

Stuart

[swd847]

I have a fix here: https://github.com/stuartwdouglas/jboss-as/tree/arqFix

I will try and get it merged when master is unfrozen

[thomas.diesler]

Thanks, I pull it in here: https://github.com/jbosgi/jboss-as/commit/aedf9fbd62cdb9f9d456ca01061023df2b9a567c

I still like to discuss what needs to change in ARQ so that your use case is supported.

ARQ allready supports @BeforeClass/@AfterClass and @Before/@After. Is it not possible to put the logic in the test? The ContextManager could be injected by a TestEnricher. Does ARQ need a notion of SetupAction?

Let me ping Aslak about this.