-
1. Re: Core Changes That Impact Components
tcunning Feb 25, 2011 3:04 PM (in response to kcbabo)David and I were talking about this on irc with one of the latest pull requests - since the person handling the pull request is already doing a clean install, and there's no hard-and-fast guarantee on the amount of time when someone will be able to process a pull request (timezones, etc) once it is submitted, might it make sense if the person doing the pull request is also the person responsible for doing the "mvn deploy" to push artifacts out to Nexus?
I'm unclear on whether we formalized who was responsible for the deploy out to Nexus, but it takes virtually no time to do and it doesn't seem like much more work to add if you are already reviewing the code pushing it in.
-
-
3. Core Changes That Impact Components
kcbabo Feb 25, 2011 6:16 PM (in response to dward)I agree. In fact, I added this to our "Development on SwitchYard" rules earlier in the week.
http://community.jboss.org/wiki/DevelopmentonSwitchYard
If you push a change to core that impacts components (e.g. core API change breaks component compile or core runtime change breaks component test), then you must push an updated set of artifacts to the snapshot repository. It is the responsibility of the person pushing the change to make sure this happens.
The other thing we can consider for snapshot builds is to let Hudson publish artifacts as a result of a successful build. Thoughts on that?
-
4. Core Changes That Impact Components
mageshbk Feb 25, 2011 7:22 PM (in response to kcbabo)The other thing we can consider for snapshot builds is to let Hudson publish artifacts as a result of a successful build. Thoughts on that?
There will be numerous snapshots published in a given day for no reason at all. It is best to publish it manually as we can judge when it needs a push to Nexus. The person submitting a pull request may indicate in his comments that a publish is also necessary, perhaps?
-
5. Core Changes That Impact Components
dward Feb 25, 2011 8:20 PM (in response to mageshbk)I agree with Magesh.