Annotation based Action classes| JBoss.org Content Archive (Read Only)

1 2 3 Previous Next 39 Replies Latest reply on Apr 19, 2011 5:27 AM by henrique.malheiro Go to original post

30. Re: Annotation based Action classes

tfennelly Jun 29, 2010 10:27 AM (in response to tfennelly)

Just posted the first draft of a Wiki page on this stuff: http://community.jboss.org/wiki/JBossESBActionAnnotations
Actions
31. Re: Annotation based Action classes

burmanm Dec 17, 2010 2:27 AM (in response to tfennelly)

Is it by design that these work differently than the old actions? There are two things which don't work:

1. Transactions aren't supported, rollback doesn't happen since BeanContainerAction wraps everything as "ActionProcessingException". The JCA adapter doesn't get RuntimeException, which is needed for the rollback to occur. This works correctly in the ActionProcessingPipeline, which detects the RuntimeException if it's running in transactional mode and throws it.

2. Terminating the action flow doesn't work anymore by setting the message as null. This works with older ActionProcessingPipeline where returning message as null causes the pipeline to die with break;. However, in the BeanContainerAction, if the return value is null the original payload is reset.

If these are intentional, they should be documented. I don't know how many hours I spent debugging our software and wondering why on earth things stopped working in certain cases. If these are unintentional, I can create JIRA tickets, and I can even submit possible patches.
Actions
32. Re: Annotation based Action classes

tfennelly Dec 17, 2010 7:03 AM (in response to burmanm)

Hi Michael. These are not intentional, so please do submit JIRAs + possible patches.

Thanks for reporting.
Actions
33. Re: Annotation based Action classes

kconner Dec 17, 2010 7:19 AM (in response to burmanm)

As Tom has already said, this is not intentional and is definitely a bug. The annotated actions should behave the same as the current interfaces.

We are looking into it now.
Actions
34. Re: Annotation based Action classes

tfennelly Dec 17, 2010 8:00 AM (in response to tfennelly)

I created 2 JIRAs for this:

https://issues.jboss.org/browse/JBESB-3547
https://issues.jboss.org/browse/JBESB-3548

And thanks again Michael.
Actions
35. Re: Annotation based Action classes

tfennelly Dec 17, 2010 10:44 AM (in response to tfennelly)

These issues are now fixed and committed to https://svn.jboss.org/repos/labs/labs/jbossesb/branches/JBESB_4_9_CP
Actions
36. Re: Annotation based Action classes

burmanm Dec 17, 2010 10:44 AM (in response to tfennelly)

Thanks, you beat me to it. At least rollbacks work fine at the moment in my configuration.
Actions
37. Annotation based Action classes

henrique.malheiro Apr 13, 2011 12:23 PM (in response to burmanm)

Hi,

I am having this problem too. Is there an easy way for me to get this fix? It would be great.

Thanks in advance.
Actions
38. Annotation based Action classes

tfennelly Apr 14, 2011 4:51 AM (in response to henrique.malheiro)
You can:

Get the 4.9.CP source, build and use it.
Get the source tag for whatever version you're using and merge over the fixes.
Wait for the fixes to come out in an official release, which I'm assuming will be 4.10.
Actions
39. Annotation based Action classes

henrique.malheiro Apr 19, 2011 5:27 AM (in response to tfennelly)

Hi,

Following your suggestions, I got the tagged version source and build it.

Annotation based action classes are now working as expected!

Thank you very much for your help.
Actions

1 2 3 Previous Next

Go to original post