Richfaces 4 and Web Flow, partial rendering problem

[bvi]

Hello, I have noticed a problem with Richfaces 4.0.0.Final and Spring Web Flow 2.3.0. I cannot say if it is Richfaces or Web Flow relevant... perhaps the two ...

I have a flow, and a transition with a <render> tag (designed to do partial rendering with web flow) ,  for instance :

<view-state id="testPage" >

<transition on="doit">

     <render fragments="myregion"/>

</transition>

</view-state>

When using an a4jcommandButton , for instance :

<a4j:commandButton action="doit" render="myregion"/>

<a4j:commandButton action="doit" render="myregion"/>

The following exception occurs :

java.lang.UnsupportedOperationException

at java.util.AbstractList.add(AbstractList.java:131)

at java.util.AbstractList.add(AbstractList.java:91)

at java.util.AbstractCollection.addAll(AbstractCollection.java:305)

at org.richfaces.context.ExtendedPartialViewContextImpl.visitActivatorAtRender(ExtendedPartialViewContextImpl.java:346)

The richfaces class ExtendedPartialViewContextImpl expects a collection of ids supporting addAll() method, but the collection provided by Web flow (via org.springframework.faces.webflow.FlowPartialViewContext.getRenderIds() ) doesnt match this requirement.

I am not sure this is a Richfaces bug, however, I submit it here ...

Best regards

[lfryc]

Hello Benoit,

the best you can do is providing us small maven-based sample application where we can reproduce the issue.

Can I ask you for doing that?

[bvi]

Yes you can :-) I will do that asap

[bvi]

Hello, here is a small maven-based project .

In the "test" flow, you can comment/uncomment the render tag to see the different behaviors with a4j:commandButton (exception raised, or not :-).

Best regards,

[lfryc]

Hello Benoit, thanks for the sample!

I will look into it next week.

[jonask]

hi im looking for a example with RF4 and spring so i used your example but i alwys get this error

java.lang.IllegalArgumentException: Unable to load class 'demo.DemoBean'

complete : http://pastebin.com/n4KdJ0qf

would be great, if you could help me with this. i used maven to import your project...

[bvi]

Do you use Eclipse/WTP ? I've had the same error on the first run of project, perhaps due to WTP.

Try to do "Maven... Update project configuration" , it will republish the project correctly, normally ....

[jonask]

yes, i use eclipse/WTP

i did how you told me and now have a problem in the project:

"classpath error: unable to find org.aspectj.lang.JoinPoint (check that aspectjrt.jar is in your classpath) fr.maif.samplewebflow Unknown Java Problem"

i think thats the problem because i cant create the bean...

[muralib12]

Hi Lukas,

did you get a chance to look into this issue. am also facing the same error.

[muralib12]

Hello Benoit,

Did you find any work around for this issue??

[muralib12]

Hi all,

this problem solved: please refer: http://blog.springsource.com/2010/08/05/spring-web-flow-2-2-0-m1-released/

i forgot to add Ajax handler.

<bean class="org.springframework.webflow.mvc.servlet.FlowHandlerAdapter">

    <property name="flowExecutor" ref="flowExecutor" />

    <property name="ajaxHandler">

        <bean class="org.springframework.faces.webflow.JsfAjaxHandler"/>

    </property>

</bean>

and used h:commandbutton+f:ajax rather a4j:commandbutton

[bvi]

Hi, no I don't think my problem is solved :-)

It occurs with Spring Web Flow 2.3.0 and it doesn't concern h:commandButton + f:ajax (work nice) but a4j:commandButton itself :-)

Cheers,

[muralib12]

Hi Benoit,

Yes, the problem is not solved. it happens even with a4j:ajax tag.

Can anybody from Rich Faces please respond. It is blocking our migration work badly.

[lfryc]

Sorry I haven't look into this issue closer yet!

Benoit, I have reproduced that issue with your sample and got a opinion that SWF implementation of PartialViewContext is invalid here,

and there is regrettably nothing we could do about it.

This issue is in FlowPartialViewContext.getRenderIds() which returns immutable collection.

return Arrays.asList(fragmentIds);

But reference implementation states that this collection should be mutable:

/**
     * <p class="changed_added_2_0">Return a
     * <code>Collection</code> of client identifiers from the current request
     * with the request parameter name {@link #PARTIAL_RENDER_PARAM_NAME}.
     * If there is no such request parameter, return an empty <code>Collection</code>.
     * These client identifiers are used to identify components that
     * will be processed during the <code>render</code> phase of the
     * request processing lifecycle.  The returned <code>Collection</code> is 
     * mutable.</p>
     *
     * @throws IllegalStateException if this method is called after
     *  this instance has been released
     *
     * @since 2.0
     */
    public abstract Collection<String> getRenderIds();

Could you please open an issue in SWF issue tracker and link it here?

[bvi]

Here is the issue : https://jira.springsource.org/browse/SWF-1480