NPE when invoke listMessageCounterAsHTML on JMS queue mbean

[jeremystone]

With HornetQ 2.2.5 we get the following stack trace when invoking listMessageCounterAsHTML on the module=JMS,name="<some_queue_name>",type=Queue mbean:

java.lang.NullPointerException

at org.hornetq.core.messagecounter.MessageCounter.getMessageCount(MessageCounter.java:205)

at org.hornetq.core.messagecounter.impl.MessageCounterHelper.listMessageCounterAsHTML(MessageCounterHelper.java:99)

at org.hornetq.jms.management.impl.JMSQueueControlImpl.listMessageCounterAsHTML(JMSQueueControlImpl.java:341)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

..etc

Looks like the MessageCounter serverQueue field is null, (this is set null as a result of a null return value from HornetQServerImpl.createQueue(...)).

Using the listMessageCounterAsHTML on the corresponding core mbean address="<address_name>",module=Core,name="<name>",type=Queue does not NPE. However when message counters are enabled, the MessageCounter.onTimer() call throws NPE (because of the null serverQueues, above) resulting in the MessageCountersPinger scheduled task exiting after its first attempted execution and never executing again (as per ScheduledExecutorService scheduleAtFixedRate contract).

This used to be OK with HornetQ 2.2.2.

Has anyone else seen this?

[clebert.suconic]

Someone had reported me that on IRC but I couldn't replicate it.

If you give me the exact steps to reproduce it. (start with an empty distribution, step by step).. We will fix it. (you may open a JIRA on that case.. if you find a way to reproduce it).

If it needs code (not just JMX-console or jconsole), please provide us some code / test.

[jeremystone]

Thanks, Clebert. I will see what I can come up with.

[jeremystone]

To reproduce:

1. Unzip JBoss 4.2.3.GA installation (also happens with later 4.2.3 service releases)
2. Integrate HornetQ 2.2.5 using the build.bat/build.sh in hornetq-2.2.5.Final\config\jboss-as-4 (following instructions in Quickstart Guide)
3. Run JBoss using run -c default-with-hornetq
4. Open jmx-console in a browser and invoke the the listMessageCounterAsHTML method on the module=JMS,name="DLQ",type=Queue mbean.

[Note: you will need to fix up the ra.xml where there appears to be a typo: TransactionManagerLocatorMethod is set twice. The first should be  setting TransactionManagerLocatorClass. Otherwise get ArrayIndexOutOfBoundsException when it tries to look up the transaction manager.]

[jeremystone]

Have created https://issues.jboss.org/browse/HORNETQ-735

[clebert.suconic]

Does it only happen on 4.2.3?

[jeremystone]

And 4.3.0.GA.CP04. Not tried JBoss 5+

[zohar_melamed]

Hi

We are seeing the same issue running 2.2.5 Final standalone.

This happens on both listMessageCounterAsHTML() and listMessageCounter()

In both cases debugging shows serverQueue to be null in MessageCounter.java....

Cheers

Z

[zohar_melamed]

and our config :

            Configuration configuration = new ConfigurationImpl();

            configuration.setPersistenceEnabled(false);

            configuration.setSecurityEnabled(false);

            configuration.setLogDelegateFactoryClassName(Log4jLogDelegateFactory.class.getName());

            configuration.setBindingsDirectory(subdirectoryInMessagingDirectory("bindings"));

            configuration.setJournalDirectory(subdirectoryInMessagingDirectory("journal"));

            configuration.setLargeMessagesDirectory(subdirectoryInMessagingDirectory("largemessages"));

            configuration.setPagingDirectory(subdirectoryInMessagingDirectory("paging"));

            configuration.setMessageCounterEnabled(true);

            configuration.setMessageCounterMaxDayHistory(14);

            configuration.setMessageCounterSamplePeriod(5000);

            configuration.setSharedStore(false);

            configuration.setPersistenceEnabled(true);

            configuration.setJournalType(JournalType.NIO);

            deleteAndRecreate(configuration.getJournalDirectory());

            deleteAndRecreate(configuration.getLargeMessagesDirectory());

            deleteAndRecreate(configuration.getPagingDirectory());

            Map<String, Object> connectionParams = new HashMap<String, Object>();

            connectionParams.put(TransportConstants.PORT_PROP_NAME, messagingServiceConfig.getMessagingPort());

            connectionParams.put(TransportConstants.HOST_PROP_NAME, messagingServiceConfig.getHost().value);

            TransportConfiguration transpConf = new TransportConfiguration(NettyAcceptorFactory.class.getName(), connectionParams);

            HashSet<TransportConfiguration> setTransp = new HashSet<TransportConfiguration>();

            setTransp.add(transpConf);

            configuration.setAcceptorConfigurations(setTransp);

            JMSConfiguration jmsConfig = new JMSConfigurationImpl();

            server = new EmbeddedJMS();

            server.setConfiguration(configuration);

            server.setJmsConfiguration(jmsConfig);

            server.start();

[clebert.suconic]

@zohar, so you are doing embedded?

[clebert.suconic]

Please, ignore my last message! :-)

[clebert.suconic]

fixed on https://svn.jboss.org/repos/hornetq/branches/Branch_2_2_AS7

That's the best branch to get it now.

Branch_2_2_EAP is under work on clustering.

trunk will be updated as soon as I finish some clustering changes.

[clebert.suconic]

Thanks for the help on fixing it...

The issue was on loading existent JMS queues. The createQueue was being ignored and returning null.

[zohar_melamed]

Thanks for the  quick fix Cedric. I'll try and test this on Monday. We are indeed using hornet in an embedded setting ,where it replaced activemq.