-
1. Re: SOAP binding and doclit
tfennelly Jul 20, 2011 6:01 AM (in response to objectiser)I'd say it should be easy enough to support both, no?
-
2. Re: SOAP binding and doclit
objectiser Jul 20, 2011 6:13 AM (in response to tfennelly)Ok I'll create a jira.
Regards
Gary
-
3. Re: SOAP binding and doclit
kcbabo Jul 20, 2011 6:47 AM (in response to objectiser)I found this earlier in the week and filed a JIRA:
https://issues.jboss.org/browse/SWITCHYARD-347
I believe that Mario is taking a look at this right now.
-
4. Re: SOAP binding and doclit
antollinim Jul 20, 2011 6:55 AM (in response to kcbabo)Hi.
Yes, I am working on it...
I'll let you know how things go.
Thanks
Mario
-
5. Re: SOAP binding and doclit
objectiser Jul 20, 2011 7:08 AM (in response to antollinim)OK thanks - I should have checked for duplicate before creating the new one
Regards
Gary
-
6. Re: SOAP binding and doclit
antollinim Jul 25, 2011 3:26 PM (in response to objectiser)Hi,
I have implemented non-wrapped doclit support.
Here is the commit: https://github.com/antollinim/components/commit/1f83c665ad8e9429054df6faa9be1aa923793678
I need Magesh' help here:
Magesh,
could you please review it? Not many lines of code have changed, it won't be diffcult for you.
I did not change anything within OutboundHandler. I think the invokeService method might need to be updated as well. Am I right?
I ran all the tests and everyhting looks good.
Thanks
Mario
-
7. Re: SOAP binding and doclit
mageshbk Jul 26, 2011 1:09 AM (in response to antollinim)Hi Mario,
Thank you for your contribution. A few comments:
1. I see no difference in getOperationName and getFirstBodyElement, was this intended?
2. Add a doc/literal bare WSDL and write a test for it, please.
3. You could do a full round test that would cover the OuboundHandler too.
4. Keep you changes to as minimal as possible. WSDLUtilTest does not seem to have any test in it. Did you miss to add them?
Magesh
-
8. Re: SOAP binding and doclit
mageshbk Jul 26, 2011 3:20 AM (in response to antollinim)You can remove this code in getOperation method as it should common for wrapped/bare styles:
Operation operation = port.getBinding().getPortType().getOperation(operationName, null, null); if (operation == null && operationName != null)
I guess you don't have to iterate through the keys (looks like it is hard coded now), rather use the first available part (we comply with WS-I profile, only one part is allowed) see getContracts inputType.
if(key.equals("parameters"))