Envers attempting to query using table name in JPQL

[gjkrupa]

We have a parent-child relationship set up for an entity using a plain link table.  This is annotated with @JoinTable and @AuditJoinTable so there is no entity for the link table itself.  The definition looks something like this...

@Entity

@Table(name = "BKG_BKCM_BKG_CMPT")

@Audited

public class BookingComponent implements Serializable {

@ManyToOne(fetch = FetchType.LAZY, optional = true)

@AuditJoinTable(name = "BKG_BKCMR_REL_AUD", inverseJoinColumns = { @JoinColumn(name = "BKCM_ID_PARENT", nullable = true, updatable = false) })

@JoinTable(name = "BKG_BKCMR_REL", joinColumns = { @JoinColumn(name = "BKCM_ID_CHILD", nullable = true, updatable = false) }, inverseJoinColumns = { @JoinColumn(name = "BKCM_ID_PARENT", nullable = true, updatable = false) })

private BookingComponent parent;

@OneToMany(mappedBy = "parent")

@AuditJoinTable(name = "BKG_BKCMR_REL_AUD", inverseJoinColumns = { @JoinColumn(name = "BKCM_ID_CHILD", nullable = true) })

private List<BookingComponent> children;

}

We've found two issues.  Firstly, when we try to retrieve a previous revision of these entities (they in turn are held in a collection in a container entity) using List<>.size() Envers seems to be constructing a JPQL query using the link table's table name which isn't valid JPQL resulting in the following exception:

org.hibernate.hql.ast.QuerySyntaxException: BKG_BKCMR_REL_AUD is not mapped [select new list(ee, e) from BKG_BKCMR_REL_AUD ee, *package-name-omitted*.BookingComponent_AUD e where ee.originalId.BookingComponent_id = e.originalId.id and ee.originalId.children_id = :children_id and e.originalId.rev_id.id <= :revision and ee.originalId.rev_id.id <= :revision and ee.rev_type != :delrevisiontype and e.rev_type != :delrevisiontype and (e.REV_ID_END.id > :revision or e.REV_ID_END is null) and (ee.REV_ID_END.id > :revision or ee.REV_ID_END is null)]

    at org.hibernate.hql.ast.util.SessionFactoryHelper.requireClassPersister(SessionFactoryHelper.java:180)

    at org.hibernate.hql.ast.tree.FromElementFactory.addFromElement(FromElementFactory.java:111)

    at org.hibernate.hql.ast.tree.FromClause.addFromElement(FromClause.java:93)

    at org.hibernate.hql.ast.HqlSqlWalker.createFromElement(HqlSqlWalker.java:327)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.fromElement(HqlSqlBaseWalker.java:3441)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.fromElementList(HqlSqlBaseWalker.java:3325)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.fromClause(HqlSqlBaseWalker.java:733)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.query(HqlSqlBaseWalker.java:584)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.selectStatement(HqlSqlBaseWalker.java:301)

    at org.hibernate.hql.antlr.HqlSqlBaseWalker.statement(HqlSqlBaseWalker.java:244)

    at org.hibernate.hql.ast.QueryTranslatorImpl.analyze(QueryTranslatorImpl.java:254)

    at org.hibernate.hql.ast.QueryTranslatorImpl.doCompile(QueryTranslatorImpl.java:185)

    at org.hibernate.hql.ast.QueryTranslatorImpl.compile(QueryTranslatorImpl.java:136)

    at org.hibernate.engine.query.HQLQueryPlan.<init>(HQLQueryPlan.java:101)

    at org.hibernate.engine.query.HQLQueryPlan.<init>(HQLQueryPlan.java:80)

    at org.hibernate.engine.query.QueryPlanCache.getHQLQueryPlan(QueryPlanCache.java:124)

    at org.hibernate.impl.AbstractSessionImpl.getHQLQueryPlan(AbstractSessionImpl.java:156)

    at org.hibernate.impl.AbstractSessionImpl.createQuery(AbstractSessionImpl.java:135)

    at org.hibernate.impl.SessionImpl.createQuery(SessionImpl.java:1770)

    at org.hibernate.envers.entities.mapper.relation.query.TwoEntityQueryGenerator.getQuery(TwoEntityQueryGenerator.java:128)

    at org.hibernate.envers.entities.mapper.relation.lazy.initializor.AbstractCollectionInitializor.initialize(AbstractCollectionInitializor.java:62)

    at org.hibernate.envers.entities.mapper.relation.lazy.proxy.CollectionProxy.checkInit(CollectionProxy.java:50)

    at org.hibernate.envers.entities.mapper.relation.lazy.proxy.CollectionProxy.size(CollectionProxy.java:55)

We've also noticed that the audit entries for the link table have a null REV_ID_END despite there being multiple revisions.

Does anyone have any idea how we might have configured this incorrectly or what could be going wrong?

We're using Hibernate core and Envers 3.6.4.Final.

[adamw]

First thing is that you need to specify the @AuditJoinTable only on the owning side of the relation (just like the @JoinTable). Try to remove the additional @AuditJoinTable, and please check if it still breaks.

Adam

[gjkrupa]

Thanks for the quick reply.  I removed the @AuditJoinTable annotation from the children field but that didn't seem to make any difference.  I also updated to version 3.6.7.Final with no luck as well.  Still getting the same error and badly formed audit table entries.

The link table looks like this:

BKCM_ID_PARENT	BKCM_ID_CHILD
1723	1723
1723	1724

(yes, it is intentional that an item should be its own parent, don't ask )

and the audit table looks like this:

REV_ID	REV_TYPE	BKCM_ID_PARENT	BKCM_ID_CHILD	REV_ID_END	REVEND_DATE_TIME
20321	(null)	(null)	1723	(null)	(null)
20329	(null)	(null)	1723	(null)	(null)
20321	(null)	(null)	1724	(null)	(null)
20329	(null)	(null)	1724	(null)	(null)

[adamw]

Ah, you have a bidirectional relation but you have a join table anyway. Interesting I'm not sure if we've got a test case for that. Unfortunately this looks like a bug ... could you report a JIRA?

Thanks,

Adam

[gjkrupa]

I'm having some trouble registering on the Hibernate JIRA but I'll keep trying.  In the meantime I've attached a Maven project to my initial post that replicates the problem using an embedded Derby DB using a subset of our Spring configuration.

[gjkrupa]

JIRA is back up and running now.  I've created a ticket for this: https://hibernate.onjira.com/browse/HHH-6661

[adamw]

Thanks!

Adam