Feature Request, support onejar-maven-plugin

[pieter.martin]

Hi,

I am using weld-se in a standalone SE app.
I am using onejar-maven-plugin to build an executable jar with all the dependencies contained in the jar.

The plugin basically packages jars inside jars and then has its own classloader to get the whole thing going.

However this completely breaks org.jboss.weld.environment.se.discovery.URLScanner as the classes are now in a non standard place.

I have added some code to URLScanner class to support the onejar-maven-plugin and my one jar together with weld is working fine.

I prefer this way over using the maven-shade-plugin as that overrides duplicate files, beans.xml for instance.

Any chance weld-se will add support for this?

Thanks
Pieter

[pmuir]

Sounds good, file a feature request in WELDX, add a patch, I think Pete R will be able to take a look :-)

[pieter.martin]

Great..., WELDX-81

[peteroyle.howardmoon.hitcity.com.au]

Thanks for the patch! I'll try to have a look at this as soon as possible...

[java_whacko]

Is this ever fixed? I am using 2.2.13 version of weld and I am getting an error on startup.

2015-06-23 22:45:58,416 DEBUG [org.jboss.weld.Bootstrap] (main) WELD-ENV-000032: Processing bean archive reference: /gw-provisioning-server.one-jar.jar!/lib/mfss-security-authentication-1.4.0-SNAPSHOT.jar

Exception in thread "main" java.lang.reflect.InvocationTargetException

        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

        at java.lang.reflect.Method.invoke(Method.java:483)

        at com.simontuffs.onejar.Boot.run(Boot.java:340)

        at com.simontuffs.onejar.Boot.main(Boot.java:166)

Caused by: java.lang.NullPointerException

        at org.jboss.weld.environment.deployment.discovery.jandex.JandexFileSystemBeanArchiveHandler.handle(JandexFileSystemBeanArchiveHandler.java:43)

        at org.jboss.weld.environment.deployment.discovery.AbstractDiscoveryStrategy.performDiscovery(AbstractDiscoveryStrategy.java:91)

        at org.jboss.weld.environment.se.Weld.createDeployment(Weld.java:210)

        at org.jboss.weld.environment.se.Weld.initialize(Weld.java:135)

        at com.medfusion.mfss.embeddable.server.EmbeddableRestServer.main(EmbeddableRestServer.java:77)

        ... 6 more

[mkouba]

Hi,

nested archives are not supported at the moment - see also [WELD-1930] Nested archive support - JBoss Issue Tracker. I'm not sure this ever worked out of the box.

[java_whacko]

But, when I look at the below issue, it seems to have been worked on.

https://issues.jboss.org/browse/WELD-595

[mkouba]

Yes, but I think the solution was to allow to provide a custom scanner component, see also Pete's comment: [WELD-595] Add support for onejar-maven-plugin - JBoss Issue Tracker

[mkouba]

Nevertheless, I've created a working prototype for WELD-1930 - see also WELD-1930 Weld SE - basic support for nested archives by mkouba · Pull Request #1046 · weld/core · GitHub. Feel free to make a review, post comments, etc.