ConversationImpl.toString thrwos Exception

[pandora]

Hi,

I am just messing around with Wicket and Weld right now, so my setup is anything else than proper. However I got this exception just from a toString() method, I don't think that's too great, since it obfuscates rather than helps.

ConversationImpl.toString

org.jboss.weld.context.ContextNotActiveException: WELD-001303 No active contexts for scope type @ConversationScoped
     at org.jboss.weld.conversation.ConversationImpl.checkConversationActive(ConversationImpl.java:79)
     at org.jboss.weld.conversation.ConversationImpl.isTransient(ConversationImpl.java:234)
     at org.jboss.weld.conversation.ConversationImpl.toString(ConversationImpl.java:199)
     at java.text.MessageFormat.subformat(MessageFormat.java:1246)
     at java.text.MessageFormat.format(MessageFormat.java:836)
     at java.text.Format.format(Format.java:140)
     at java.text.MessageFormat.format(MessageFormat.java:812)
     at ch.qos.cal10n.MessageConveyor.getMessage(MessageConveyor.java:89)
     at org.jboss.weld.logging.WeldMessageConveyor.getMessage(WeldMessageConveyor.java:78)
     at org.slf4j.cal10n.LocLogger.trace(LocLogger.java:72)
     at org.jboss.weld.bean.proxy.ClientProxyMethodHandler.invoke(ClientProxyMethodHandler.java:114)
     at org.jboss.weld.util.CleanableMethodHandler.invoke(CleanableMethodHandler.java:43)
     at org.jboss.weld.conversation.ConversationImpl$$javassist0.getUnderlyingId(ConversationImpl$$javassist0.java)
     at org.jboss.weld.wicket.WeldRequestCycle.onRequestTargetSet(WeldRequestCycle.java:100)
     at org.apache.wicket.RequestCycle$1.add(RequestCycle.java:253)

[andygibson.contact.andygibson.net]

By default, Weld conversations work out of the box with JSF as it uses the phase listeners but you need some additional config to get conversations working in wicket (basically starting and propagating/ending the conversation over the span of the wicket request). Here it looks like you haven't set up the conversation context at the start of the request.

You can find out more info in the Wicket CDI Integration docs

Cheers,

Andy Gibson

[pandora]

thanks for that.

Still, don't you consider it a bug that a RuntimeException gets thrown? The action that led to it was actually the weld TRACE level message that said that there was no active conversation context. So weld creates a TRACE log message that leads to a RuntimeException because of toString(). To me that does not seem right. Apart from that, several IDEs use the toString method as well to display object information for debugging, so a toString method throwing Runtime Exceptions just should be avoided IMO.

[andygibson.contact.andygibson.net]

Oh yeah, I still think its a bug that an exception gets thrown, I was just pointing out that it sounded like your app may not be configured properly. I agree that a toString() shouldn't throw exceptions like that.

Cheers,

Andy Gibson

[swd847]

It looks like this is fixed in trunk