security of class member variables

[ericjung2]

Hi,

I've noticed a lot of the Seam samples don't specify private for member variables in non-entity classes. Here's an example. Is there a reason for this, or is it just an oversight?

Thanks,
Eric

[shane.bryzak]

No particular reason for this, you can make them private if you want to.

[ericjung2]

Thanks for the reply, Shane.

Can I submit patches to make these private? It goes with convention, and avoids confusion on the part of new Seam users (like me). I didn't know if perhaps they were left package-private (instead of private) because Seam does some reflection or introspection requiring that (that said, I do realize you can reflect private class variables, so that added to my confusion even more)

Eric

[shane.bryzak]

I meant you can make them private in your own application ;p  I'm sure we have many, many places throughout our examples where the instance variables are package-scope, but to be honest I think we have more important issues to concentrate our limited development resources on.  However, if you'd really like to see them all changed and are prepared to create the patches (and test them) then of course feel free to submit to JIRA.