IdentifierStrategy issue with non-entity classes

[zergspirit]

Hi.

I'm trying to handle permissions using the new Seam Security framework, and more specifically, I'm trying to persist permission related to a non-entity object.
I read the doc, but I'm not quite sure what I'm supposed to do.
I'd have thought that there was a default behaviour to handle non-entity object passed to PermissionManager.grantPermission, taking the @Name annotation or at least the name of the object's class, but it's not the case.

For instance, I have a really simple class :

public class TestClass {

}

And I try to grant a permission on this class to my Role testRole:

PermissionManager.instance().grantPermission(new org.jboss.seam.security.permission.Permission(new TestClass(),"test",new Role("testRole")));

So, if I understood the doc clearly, I'd suppose I would end up having a permission persisted through my JpaPermissionStore having TestClass as target and test as action, but it's persisted with an empty target instead.
I tryed to annotate this class using

@Name("TestClass")

or

@Identifier(name="TestClass")

but it didn't change anything.

Am I suppose to create my custom Identifier Strategy, or is there something I missed about a default behaviour regarding non-entity classes?

[zergspirit]

I up this one, since I still couldn't figure out what's wrong here.

[shane.bryzak]

The identifier strategy is intended to generate unique ID's for specific object instances.  For entities this is easy because they are required to have an @Id field.  For non entity classes, you need to develop your own identifier strategy which returns an identifier based on some unique aspect of your object instance.  TestClass isn't a unique identifier, as it doesn't distinguish between two individual instances of the TestClass class.

[gaboo.gael.livre-rare-book.com]

From the seam 2.1 documentation :

15.6.10.3.6. ClassIdentifierStrategy
This identifier strategy is used to generate unique identifiers for classes, and will use the value
of the name (if specified) in the @Identifier annotation. If there is no name property provided,
then it will attempt to use the component name of the class (if the class is a Seam component), or
as a last resort it will create an identifier based on the name of the class (excluding the package
name). For example, the identifier for the following class will be "customer":
@Identifier(name = "customer")
public class Customer {

So there is something I don't get, because as I understand the documentation, it should generate a target name from the class ... ? Or what is this for ?

[shane.bryzak]

That's correct, if you are passing in a Class.  In your example though, you pass in an object instance (new TestClass()), not a Class instance.

[gaboo.gael.livre-rare-book.com]

Well, thanks, this is what we're looking for !

I think it could be more clear in the documentation though :)