RichFaces listShuttle always considered invalid by <s:decorate>

[hermida.leandro.hermida.gmail.com]

Hello,

When my form displays the RichFaces listShuttle form field is always considered #{invalid} by <s:decorate>.  So it trips up the wrong rendering yet there is nothing in <s:message/>.  Does anyone know why this goes on, especially when the form is initially displayed so no validation attempt has even occurred?

Here is my formFieldDecorate.xhtml:

<ui:composition xmlns="http://www.w3.org/1999/xhtml"
                xmlns:s="http://jboss.com/products/seam/taglib"
                xmlns:h="http://java.sun.com/jsf/html"
                xmlns:f="http://java.sun.com/jsf/core"
                xmlns:ui="http://java.sun.com/jsf/facelets"
                xmlns:a4j="http://richfaces.org/a4j"
                xmlns:rich="http://richfaces.org/rich">

    <div class="entry #{invalid ? 'errorEntry' : ''}">
        <s:div styleClass="errorMessage" rendered="#{invalid}">
            <h:panelGrid columns="2" cellpadding="0" cellspacing="0" border="0">
                <h:graphicImage value="/img/attention.gif"
                                width="18" height="18"
                                styleClass="attentionImage"/>
                <s:span styleClass="attentionMessage">&#160;<s:message/></s:span>
            </h:panelGrid>
        </s:div>
        <div class="label">
            <ui:insert name="label"/>
            <s:span styleClass="required" rendered="#{required}">*</s:span>:
        </div>
        <div class="input">
            <s:validateAll>
                <ui:insert/>
            </s:validateAll>
        </div>
    </div>

</ui:composition>

and here is the area of the form with the listShuttle:

<s:decorate id="investigationTypesDecorate"
          template="/layout/formFieldDecorate.xhtml">
          <ui:define name="label">Types</ui:define>
          <rich:listShuttle listsHeight="200"
               sourceValue="#{investigationCreateAction.availableInvestigationTypes}"
               targetValue="#{investigationCreateAction.selectedInvestigationTypes}"
               sourceCaptionLabel="Available Types"
               targetCaptionLabel="Selected Types" orderControlsVisible="false"
               fastOrderControlsVisible="false" converter="ontologyTermDTOConverter"
               var="type">
               <rich:column width="18">
                    <h:graphicImage value="/img/ico_common.gif" />
               </rich:column>
               <rich:column>
                    <h:outputText value="#{type.term}" />
               </rich:column>
          </rich:listShuttle>
     </s:decorate>

[hermida.leandro.hermida.gmail.com]

Hello,

I have been able to reproduce this with Seam 2.1.0.GA and a brand new default Seam Web Project generated by the new seam-gen.  Using the layout/edit.xhtml decorator that comes with the default project if you do this:

<s:decorate id="investigationDesignTypesField" template="layout/edit.xhtml">
                <ui:define name="label">Investigation Design Types</ui:define>
                <rich:listShuttle sourceValue="#{investigationCreateAction.availableInvestigationTypes}"
                                  targetValue="#{investigationCreateAction.selectedInvestigationTypes}"
                                  sourceCaptionLabel="Available Types"
                                  targetCaptionLabel="Selected Types"
                                  orderControlsVisible="false"
                                  fastOrderControlsVisible="false"
                                  converter="ontologyTermDTOConverter"
                                  var="type">
                    <rich:column>
                        <h:outputText value="#{type.term}"/>
                    </rich:column>
                </rich:listShuttle>
            </s:decorate>

It display everything as red as if it were invalid... does anyone know why Seam thinks it's invalid?  Even if I put a <rich:listShuttle> with no parameters it thinks it's invalid...

leandro

[hermida.leandro.hermida.gmail.com]

Hi,

Does anyone have any idea about this??  I have reproduced the problem using a new Seam Web Project using 2.1.0.GA...

any help would be much appreciated :)
leandro

[seanmon]

Hi,

Just wanted to say I've been experiencing this too. Anybody find a solution to this yet?

Thanks.

[mwohlf]

same here with jboss-seam-2.1.1.GA,
anyone has a workaround?

[wark2007]

Same problem for me with 2.1.1.GA. Anybody found a solution? Can anybody of the Seam developers reproduce it?

[tamerg]

hi,
I solved this with making new layout for s:decorate and replacing s:message with h:message using for attiribute.

[mtpettyp]

It looks like org.richfaces.component.html.HtmlListShuttle.java shadows its parent class (org.ajax4jsf.component.UIDataAdaptor) valid field.  The CDK is generating a new valid field and sets it to false. 

Debugging through the Seam source code org.jboss.seam.ui.util.Decoration.hasMethod() calls:

// If the component has failed validation, then it's invalid
if ( ! ( (EditableValueHolder) component ).isValid() ) return true;

This is why the listShuttle shows as invalid.

Looking at similar Richfaces controls (calendar, inplaceInput), the CDK is smart enough not to redefine valid and it's setters and getters (though both those control inherit from UIInput and not org.ajax4jsf.component.UIDataAdaptor like the listShuttle does)

I'm rebuilding Richfaces 3.3.0 and modifying the valid property in listShuttle.xml as:

<property hidden="true" el="false">
<name>valid</name
<defaultvalue>true</defaultvalue>
</property>

Assuming this works I'll submit a bug to the Richfaces team.

[mtpettyp]

I was wrong about org.ajax4jsf.component.UIDataAdaptor already defining isValid/setValid.  That was defined in an inner class in that file, not in the main class itself.

The fix is to modify listShuttle.xml as I mentioned above. 

[mtpettyp]

https://jira.jboss.org/jira/browse/RF-6972