-
1. Re: Seam Remoting - Marshalling bug
pgmjsd Apr 9, 2009 10:08 PM (in response to pgmjsd)We're getting hit pretty badly now by this bug. The patch we uploaded to JIRA works well, and we'll be deploying it to production soon. Maybe it could sneak into 2.1.2? :)
-
2. Re: Seam Remoting - Marshalling bug
shane.bryzak Apr 14, 2009 10:41 AM (in response to pgmjsd)How does the performance of the ThreadLocal compare with just creating a new SimpleDateFormat instance each time?
-
3. Re: Seam Remoting - Marshalling bug
pgmjsd Apr 14, 2009 9:00 PM (in response to pgmjsd)
Shane Bryzak wrote on Apr 14, 2009 10:41:
How does the performance of the ThreadLocal compare with just creating a new SimpleDateFormat instance each time?The difference was not measurable in some simple tests we did. The patch uses thread local because that was more similar to the existing code.
-
4. Re: Seam Remoting - Marshalling bug
shane.bryzak Apr 14, 2009 11:39 PM (in response to pgmjsd)I've fixed this in SVN, by using the new instance approach (my research suggested that the performance of creating a new instance vs thread local is negligible).
-
5. Re: Seam Remoting - Marshalling bug
pgmjsd Apr 15, 2009 7:08 PM (in response to pgmjsd)
Shane Bryzak wrote on Apr 14, 2009 23:39:
I've fixed this in SVN, by using the new instance approach (my research suggested that the performance of creating a new instance vs thread local is negligible).Great! I guess you folks have already branched for the release so it's probably too late for that.
-
6. Re: Seam Remoting - Marshalling bug
pgmjsd Apr 16, 2009 4:09 PM (in response to pgmjsd)
Shane Bryzak wrote on Apr 14, 2009 23:39:
I've fixed this in SVN, by using the new instance approach (my research suggested that the performance of creating a new instance vs thread local is negligible).Seems like thread local can be very much faster than creating a new instance:
take a look at this