AbstractViewTestCase and exception when parsing JSP?

[olivier.mallassi]

hi all,

i am trying to realise an AbstractViewTestCase test case and i got the following stackt trace

junit.framework.AssertionFailedError: Exception in constructor: testActions (java.lang.RuntimeException: Could not parse file 'C:\dev\
\mycompany-appliblanche\trunk\mycompany-applicationblanche-jsf\src\main\webapp\views\search-autocomplete.jsp'
 at org.jboss.jsfunit.analysis.AbstractViewTestCase.parseResources(AbstractViewTestCase.java:117)
 at org.jboss.jsfunit.analysis.AbstractViewTestCase.<init>(AbstractViewTestCase.java:98)
 at org.jboss.jsfunit.analysis.AbstractViewTestCase.<init>(AbstractViewTestCase.java:51)
 at org.jboss.jsfunit.analysis.AbstractViewTestCase.<init>(AbstractViewTestCase.java:55)
 at fr.mycompany.ViewTestCase.<init>(ViewTestCase.java:18)
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
 at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)
 at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)
 at java.lang.reflect.Constructor.newInstance(Unknown Source)
 at junit.framework.TestSuite.createTest(TestSuite.java:131)
 at junit.framework.TestSuite.addTestMethod(TestSuite.java:114)
 at junit.framework.TestSuite.<init>(TestSuite.java:75)
 at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestLoader.getTest(JUnit3TestLoader.java:102)
 at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestLoader.loadTests(JUnit3TestLoader.java:59)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:445)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)
 at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196)
Caused by: org.xml.sax.SAXParseException: The markup in the document preceding the root element must be well-formed.
 at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
 at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source)
 at javax.xml.parsers.DocumentBuilder.parse(Unknown Source)
 at org.jboss.jsfunit.analysis.AbstractViewTestCase.parseResources(AbstractViewTestCase.java:115)
 ... 17 more
)
 at junit.framework.Assert.fail(Assert.java:47)
.....

The JSP i wanna test starts like this

<%@ taglib uri="http://java.sun.com/jsf/html" prefix="h"%>
<%@ taglib uri="http://java.sun.com/jsf/core" prefix="f"%>
<%@ taglib uri="http://richfaces.org/a4j" prefix="a4j"%>
<%@ taglib uri="http://richfaces.org/rich" prefix="rich"%>

<%@ taglib uri="http://www.mycompany.fr/jsf/component" prefix="mycompany"%>

<f:view

so this page is not an XML document....

does JSFUnit only work with JSPX pages? it seems so because if i replace <%@taglib with <f:view xmlns:h="..., the test works.
can you give me clues about the interest of using JSPX instead of JSP? for me this is quite the same...

many thx

[ssilvert]

JSFUnit itself does not require well-formed JSP's. For the in-container tests, you can test any valid JSF application.

However, I'm pretty certain that the static analysis tools do require that your views be well-formed. I've asked Dennis, who wrote the static analysis tool to comment on the issue.

Stan

[dennisbyrne]

The static analysis assumes the .xhtml or .jsp files are well formed XML. If you are interested in adding this feature to the code base, please make sure you talk to me about how you'd like to go about doing it. I'd rather keep something like this as unobtrusive as possible.

[olivier.mallassi]

many thx for your answers.

I will keep things easy and make my pages XML compliant...in fact i guess i will use Facelets for templating so..

one more thing concerning AbstractViewTestCase.
if the faces-config.xml is formatted this way (all inline...)

<managed-bean>
 <managed-bean-name>MenuBean</managed-bean-name><managed-bean-class>fr.generali.applicationblanche.jsf.menu.MenuBean</managed-bean-class>

everything works well.

If the file is formatted (automatically) this way,

<managed-bean>
 <managed-bean-name>MenuBean</managed-bean-name>
 <managed-bean-class>
 fr.generali.applicationblanche.jsf.menu.MenuBean
 </managed-bean-class>

things are getting worse. In fact, it seems that in the method ViewConfigReconciler.reconcile(String path, String el), the statement list.item(0).getNextSibling(); returns \n\t\t in the second case.

once more thx for your answers.

[dennisbyrne]

Thanks for finding this Olivier. That's a bug. Can you create an issue in JIRA and just assign it to me?

http://jira.jboss.com/jira/browse/JSFUNIT

[olivier.mallassi]

Here it is
http://jira.jboss.com/jira/browse/JSFUNIT-63

i guess, i do not have the right to assign you on this task.