org.jboss.seam.security.passwordHash should be stateful

[fuzzy333]

org.jboss.seam.security.passwordHash is annotated with

@Scope(STATELESS)
@Name("org.jboss.seam.security.passwordHash")
@Install(precedence = BUILT_IN)
@BypassInterceptors

so a stateless component (potentially one shared instance for all, not thread safe) and a few lines down we have:

private String hashAlgorithm = null;
private int saltLength = 8;

This is just plain wrong or am I missing/forgetting something?

[fuzzy333]

...and I suppose I should mention that those attributes are mutable:

   public String getHashAlgorithm()
   {
      return hashAlgorithm;
   }
   
   public void setHashAlgorithm(String hashAlgorithm)
   {
      this.hashAlgorithm = hashAlgorithm;
   }
   
   public int getSaltLength()
   {
      return saltLength;
   }
   
   public void setSaltLength(int saltLength)
   {
      this.saltLength = saltLength;
   }