implicit JPA subsystem dependencies don't prevent java.lang.ClassNotFoundException: org.hibernate.criterion.Projection

[rhanus]

Hi,

my ejbjar inside an ear uses PersistenceContext annotation so that it should be a JPA subsystem as described here

@PersistenceContext private EntityManager em;

I also use hibernate criterion classes there:

((Session) entityManger.getDelegate()).createCriteria(type).setProjection(Projections.rowCount());

but I'm getting CNFE during deployment of ear:

22:07:33,733 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-1) MSC00001: Failed to start service jboss.deployment.subunit."project.ear"."bean.jar".POST_MODULE: org.jboss.msc.service.StartException in service jboss.deployment.subunit."project.ear"."bean.jar".POST_MODULE: Failed to process phase POST_MODULE of subdeployment "bean.jar" of deployment "project.ear"

    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:121)

    at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1824)

    at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1759)

    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [:1.6.0_29]

    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [:1.6.0_29]

    at java.lang.Thread.run(Thread.java:662) [:1.6.0_29]

Caused by: java.lang.RuntimeException: Error getting reflective information for class org.project.bean.sever.Admin

    at org.jboss.as.server.deployment.reflect.DeploymentReflectionIndex.getClassIndex(DeploymentReflectionIndex.java:70)

    at org.jboss.as.ee.metadata.MethodAnnotationAggregator.runtimeAnnotationInformation(MethodAnnotationAggregator.java:59)

    at org.jboss.as.ejb3.deployment.processors.merging.TimerMethodMergingProcessor.handleAnnotations(TimerMethodMergingProcessor.java:64)

    at org.jboss.as.ejb3.deployment.processors.merging.AbstractMergingProcessor.processComponentConfig(AbstractMergingProcessor.java:87)

    at org.jboss.as.ejb3.deployment.processors.merging.AbstractMergingProcessor.deploy(AbstractMergingProcessor.java:72)

    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:115)

    ... 5 more

Caused by: java.lang.NoClassDefFoundError: org/hibernate/criterion/Projection

    at java.lang.Class.getDeclaredFields0(Native Method) [:1.6.0_29]

    at java.lang.Class.privateGetDeclaredFields(Class.java:2291) [:1.6.0_29]

    at java.lang.Class.getDeclaredFields(Class.java:1743) [:1.6.0_29]

    at org.jboss.as.server.deployment.reflect.ClassReflectionIndex.<init>(ClassReflectionIndex.java:57)

    at org.jboss.as.server.deployment.reflect.DeploymentReflectionIndex.getClassIndex(DeploymentReflectionIndex.java:66)

    ... 10 more

Caused by: java.lang.ClassNotFoundException: org.hibernate.criterion.Projection from [Module "deployment.project.ear.bean.jar:main" from Service Module Loader]

    at org.jboss.modules.ModuleClassLoader.findClass(ModuleClassLoader.java:191)

    at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:361)

    at org.jboss.modules.ConcurrentClassLoader.performLoadClassChecked(ConcurrentClassLoader.java:333)

    at org.jboss.modules.ConcurrentClassLoader.performLoadClass(ConcurrentClassLoader.java:310)

    at org.jboss.modules.ConcurrentClassLoader.loadClass(ConcurrentClassLoader.java:103)

    ... 15 more

if I add explicit subdeployment dependency to org.hibernate the CNFE disappears:

<jboss-deployment-structure>

  <ear-subdeployments-isolated>false</ear-subdeployments-isolated>

  <deployment>

    <dependencies>

      ...

    </dependencies>

  </deployment>

  <sub-deployment name="bean.jar">

    <dependencies>

      <module name="org.hibernate"/>

    </dependencies>

is this expected behaviour if I use org.hibernate classes explicitly then I should list org.hibernate dependency ?

R.

[smarlow]

What version of AS7 are you using?  Have you tried the nightly build yet? Download link is here.

[rhanus]

I'm using 7.0.2, tomorrow I will try out 7.1.0.Beta1 as well as latest nightly build

[smarlow]

After recreating the issue with 7.1.0.Beta1 or the nightly build, enable DEBUG logging for org.jboss.as.jpa and attach the server.log output here.  Some tips for enabling logging are here.

I expect to see messages like the following:

"added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to %s"

"added (default provider) %s dependency to application deployment (since %d PU(s) didn't specify %s"

"added %s dependency to application deployment"

They should give us a better idea of the dependencies that have been added for your deployment.

[rhanus]

Sorry for delay I'm experiencing some difficulties with deployment to 7.1

[rhanus]

ok I can reproduce the problem on 7.1.0.Beta1

I maintain following deployment structure:

service.sar

common.sar

project.ear

- app.war

- bean.jar

- common.jar

-- META-INF/persistence.xml

server.log filtered out to org.jboss.as.jpa:

16:57:29,203 DEBUG [org.jboss.as.jpa] (MSC service thread 1-1) added javax.persistence.api dependency to service.sar

16:57:29,214 DEBUG [org.jboss.as.jpa] (MSC service thread 1-1) added javax.persistence.api dependency to common.sar

16:57:33,576 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to project.ear

16:57:33,577 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added (default provider) org.hibernate dependency to application deployment (since 1 PU(s) didn't specify jboss.as.jpa.providerModule)

16:57:33,580 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added org.hibernate dependency to application deployment

16:57:33,583 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to app.war

16:57:33,586 DEBUG [org.jboss.as.jpa] (MSC service thread 1-1) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to bean.jar

[smarlow]

The bean.jar module, is getting the javax.persistence.api module dependency but not the org.hibernate module.  Perhaps we could arrange for the persistence provider module dependency to be injected by enhancing JPAAnnotationParseProcessor to express the need to the JPADependencyProcessor. 

Could you file a JPA enhancement request for this change.  Use this link.

[rhanus]

is this an enhancement or a bug ?

developer guide states that a JPA (Hibernate) subsystem should add following deps if a trigger condition is met:

• javaee.api
• org.jboss.as.jpa
• org.hibernate
• org.javassist

>> added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to bean.jar

org.hibernate is obviously missing

[smarlow]

I think your right, file a bug, same link. 

Can you attach a test case to the jira?  Or a patch to the  as7 testsuite?

[rhanus]

issue has been created

[smarlow]

Radim,

Thank you for reporting this issue and creating the jira for it. 

If you want to create a testsuite case for this issue, look at the hacking AS7 page to get started.

Or attaching a test case to the jira is also fine (a test ear that recreates the problem).

I can give additional guidance on creating a testsuite test for this, if you ask.  If you want to submit a fix for the bug, I can give guidance for that as well (we can talk on IRC server=freenode channel=#jboss-as7 or here).

Scott

[rhanus]

Hi Scott,

actually I am very busy I can only promise to attach a sample failing ear

if I would have some time during weekend I try to create a testsuite case

then we will see -:) nevertheless thanks for your offer

Radim

[smarlow]

I have a potential fix in branch https://github.com/scottmarlow/jboss-as/tree/earsubmodules if anyone wants to build it and test with it.

[rhanus]

Hi Scott,

thanks for your effort i'm gonna try it out during weekend

R.

[rhanus]

sorry for delay I've experienced some difficulties regarding to deployment into 7.1.Final.SNAPSHOT with https connector required and having keystore file (solved by a magic attribute native="false" in the web subsystem)

ok it's fixed in build 547 (at least for me)

now hiberate dependency is added into particular (sub)deployment(s)

16:03:30,254 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to project.ear

16:03:30,258 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added (default provider) org.hibernate dependency to project.ear (since 1 PU(s) didn't specify jboss.as.jpa.providerModule)

16:03:30,260 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added org.hibernate dependency to application deployment

16:03:30,262 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to bean.jar

16:03:30,264 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added (default provider) org.hibernate dependency to bean.jar (since 1 PU(s) didn't specify jboss.as.jpa.providerModule)

16:03:30,266 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added org.hibernate dependency to application deployment

16:03:30,267 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added javax.persistence.api, javaee.api, org.jboss.as.jpa, org.javassist dependencies to app.war

16:03:30,270 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added (default provider) org.hibernate dependency to app.war (since 1 PU(s) didn't specify jboss.as.jpa.providerModule)

16:03:30,272 DEBUG [org.jboss.as.jpa] (MSC service thread 1-2) added org.hibernate dependency to application deployment

thanks Scott !!!