JMSConnectionFactory ignoring CF.preACK attribute

[clebert.suconic]

The JMSConnectinFactory (HornetQConnectionFactory) is ignoring the preACK attribute set at the server side.

The only way to set pre-ACK is by defining ACK mode at the client side as HornetQSession.PRE_ACKNOWLEDGE,

HornetQSession.createSessionInternal is ignoring the server's side preACK attribute.


https://jira.jboss.org/jira/browse/HORNETQ-116

[clebert.suconic]

I mean, that is happening on HornetQConnection::createSession -> HornetQConnection::createSessionInternal (not on the CF)

[timfox]

I don't think the server side is relevant.

The attribute will be ignored even if you create the connection factory programmatically on the client side.

[clebert.suconic]

I don't think the server side is relevant.

Yes... I meant the attribute defined at the CF.

[clebert.suconic]

I believe I should still ignore PRE-ACK on SessionTransacted.

I' m not sure about AUTO_ACK:

if (acknowledgeMode == Session.SESSION_TRANSACTED)
 {
 session = sessionFactory.createSession(username, password, isXA, false, false, false, transactionBatchSize);
 }
 else if (acknowledgeMode == Session.AUTO_ACKNOWLEDGE)
 {
 session = sessionFactory.createSession(username, password, isXA, true, true, false, 0);
 }
 else if (acknowledgeMode == Session.DUPS_OK_ACKNOWLEDGE)
 {
 session = sessionFactory.createSession(username, password, isXA, true, true, sessionFactory.isPreAcknowledge(), dupsOKBatchSize);
 }
 else if (acknowledgeMode == Session.CLIENT_ACKNOWLEDGE)
 {
 session = sessionFactory.createSession(username, password, isXA, true, false, sessionFactory.isPreAcknowledge(), transactionBatchSize);
 }
 else if (acknowledgeMode == HornetQSession.PRE_ACKNOWLEDGE)
 {
 session = sessionFactory.createSession(username, password, isXA, true, false, true, transactionBatchSize);
 }

[clebert.suconic]

I have sent a message on the dev-list, since the forum was down at the time. Posting it here now since the forum is back:

http://lists.jboss.org/pipermail/hornetq-dev/2009-August/000006.html

"Clebert on hornetq devlist" wrote:

I just wrote a quick test, and rollback wouldn't work if pre-ack. So..
what' s the expected semantic of pre-ACK on transactions?


IMIO, preACK should be ignored if SessionType = Transacted (and that
should be of course documented):


The test is committed as
org.hornetq.tests.integration.jms.client.PreACKJMSTest


The failing test is disabled_testPreACKTransactional. To run it you can
simply remove the disabled.