-
1. Re: Easier access to the Netty version identifier
trustin Aug 27, 2009 12:00 AM (in response to trustin)I forgot to mention that this feature will be included in 3.1.3.GA which will be released pretty soon.
-
2. Re: Easier access to the Netty version identifier
ataylor Sep 9, 2009 5:11 AM (in response to trustin)I'm adding a log.info in the netty acceptor startup and a log.debug in the nettyconnector
-
3. Re: Easier access to the Netty version identifier
timfox Sep 9, 2009 8:59 AM (in response to trustin)We should add a log.warn if the netty version is not the expected netty version for the JBM release.
-
4. Re: Easier access to the Netty version identifier
ataylor Sep 9, 2009 9:39 AM (in response to trustin)should we tie a netty version to a HornetQ version? This would make it impossible for users to drop new versions of netty in forpatches etc, maybe allow a specific version or greater to be used. Also how would we specify the netty version that should be used for a release?
-
5. Re: Easier access to the Netty version identifier
timfox Sep 9, 2009 9:45 AM (in response to trustin)We don't want to tie JBM version to netty version for the reasons you mention, however a warning is useful so we can let users easily discover common errors due to using the wrong versions.
We could specify the expected netty version in the hornetq-version.properties file, and check it both on client and server side on when a connector/acceptor is created. -
6. Re: Easier access to the Netty version identifier
ataylor Sep 9, 2009 10:03 AM (in response to trustin)Ok, i should be able to create this dynamically during the build from the netty Version class.
-
7. Re: Easier access to the Netty version identifier
timfox Sep 9, 2009 10:07 AM (in response to trustin)Not sure I follow, what are you intending to create?
-
8. Re: Easier access to the Netty version identifier
ataylor Sep 9, 2009 10:23 AM (in response to trustin)I meant update the netty version number in the hornetq-properties.xml file at build time rather than having to change it every time.
-
9. Re: Easier access to the Netty version identifier
timfox Sep 22, 2009 8:28 AM (in response to trustin)Is this done?
Is there a JIRA for it? -
10. Re: Easier access to the Netty version identifier
ataylor Sep 22, 2009 9:08 AM (in response to trustin)yes its done, i'll add a JIRA so it is tracked.