Commit comments

[plugtree]

Guys, I know this can be OT but I couldn't find this anywhere. Are there any standard for the SVN commit comments?

Sorry if this information is anywhere on the wiki or the site, I couldn't find it.

Plugtree
www.plugtree.com

[timfox]

If you're working on a JIRA, the normal convention is to add the URL of the JIRA in the commit comment, along with (optionally) some description of the commit.

BTW Diego, I have now added you as a SVN committer on the project :)

[plugtree]

Great! Thanks! I was just making sure because the Infinispan guys have a rather different convention. I'm going to commit https://jira.jboss.org/jira/browse/HORNETQ-24 now.

[clebert.suconic]

We try to run "ant dev-tests" before each commit.

Some of the class isolations are only tested on the build.

We have the build automated through hudson, and we had a few failures.. (no big deal.. they are here to watch it for us). so I commented out one of the tests.

The current jms-tests tree is some left over from jbm-1.4 and that will eventually die. new tests need to go under integration-tests. There are a bunch of JMS Tests already there.

I know you uncommented those tests (which is fine), but it seems the tests that was causing the compilation error is a new test.


We can talk this over IRC if you like.

[plugtree]

Clebert, sorry about that. Run the tests but didn't realize the dev tests targets. Is there anything I can do to fix it?
Sorry again.

[clebert.suconic]

As I told you.. don't worry about it :-)

First: It was our fault that we didn documnent about the JMSTests being deprecated... so that's our fault.. not yours.

Second: there is only one way to break the build or make any other mistake. Doing stuff :-) So... don worry again.


And actually... thanks for the contributions... It's really great to have you on board.

I only informed on the forum so you wouldn't feel like I was reverting your changes... that's all.

[timfox]

Hehe don't worry, breaking the build is a right of passage ;)

Actually what we should do is create a wiki page for new contributors which explains what tests to run etc.

Want to volunteer?

The wiki page can contain

1) Link to code style wiki page
2) SVN commit comments
3) What tests to run
4) What all the test targets mean
5) Version of JDK to use
etc

[timfox]

I started a new page here:

http://www.jboss.org/community/wiki/Gettingstartedasanewcommitter

[plugtree]

Sure, I will enhance the one you created. BTW, I think Referenceable is done to a part (the one tested in the dev-tests). But the RA adapter is not Referenceable (at least on the dev-tests).

What should I do? Should I move the Referenceable tests to integration tests?