5 Replies Latest reply on Sep 28, 2009 4:54 PM by clebert.suconic

    ReferenceableTest

    timfox

      Should the ManagedConnectionFactory be Referenceable?

      If it's not already Serializable then that means it can't have been put in JNDI *anyway*. So there's no need to make it Referenceable.

      Regarding ReferenceableTest, this can stay in JMS tests for now, since I believe this is actually an old test, not a new one that Diego added.

        • 1. Re: ReferenceableTest
          clebert.suconic

           

          Regarding ReferenceableTest, this can stay in JMS tests for now, since I believe this is actually an old test, not a new one that Diego added.


          Yes.. there was only one new test on ReferenceableTest, added to test the JCA Adaptor as referenceable, which is now commented out.

          All the others were already there before.

          • 2. Re: ReferenceableTest
            timfox

            If the commented out test code is no longer needed, it should be removed.

            • 3. Re: ReferenceableTest
              clebert.suconic

              I commented out because the build was broken. I didn't know if the test was valid or not.


              If it's not valid as we don't require Referencable on the RA adapter, we can just remove it then.

              • 4. Re: ReferenceableTest
                clebert.suconic

                Ah... duh... Sorry Tim...


                I read it wrong berfore.. I read it again now.. I thought you were blaming me for having it commented out...


                I'm paranoid.. it's monday.. so.. ignore me :-)

                • 5. Re: ReferenceableTest
                  clebert.suconic

                  BTW: I have removed the test.

                  We can recover it if we find a good reason later