LargeMessageTest hanging

[ataylor]

LargeMessageTest:testPageOnLargeMessage was hanging because of producer flow control. Ive set the AddressFullMessagePolicy to PAGE for this test and it now works ok. I'm not sure whether there may be an issue with large message and blocking tho. If the message size is larger that the window size should this work?

[timfox]

Could you just set the default address full message policy back to PAGE for now?

[ataylor]

Ive applied the same fix to PagingStoreImplTest

[ataylor]

"timfox" wrote:
Could you just set the default address full message policy back to PAGE for now?

If you like but i have fixed the tests for now. I still think its a better out of the box configuration. Maybe we could have the default mode set on the configuration?

[timfox]

Problem is, I have a suspicion that some of the paging tests don't explicitly set the mode to PAGE, they just assume the default is PAGE. This could mean the tests silently pass when we change default to BLOCK, but actually they're not doing any paging.

Clebert needs to check this.

[ataylor]

"timfox" wrote:
Problem is, I have a suspicion that some of the paging tests don't explicitly set the mode to PAGE, they just assume the default is PAGE. This could mean the tests silently pass when we change default to BLOCK, but actually they're not doing any paging.

Clebert needs to check this.

I can go thru and check them if you want, shouldnt take too long.

[timfox]

Ok fair enough.

I guess if you just go through every paging test and make sure it explicitly sets mode to PAGE that should be enough.

There are paging tests scattered in various different places though.