This content has been marked as final.
Show 5 replies
-
1. Re: LargeMessage deliverer - https://jira.jboss.org/jira/br
timfox Nov 2, 2009 8:16 AM (in response to clebert.suconic)What do you mean "create a new file on Journal" ?
-
2. Re: LargeMessage deliverer - https://jira.jboss.org/jira/br
clebert.suconic Nov 2, 2009 8:17 AM (in response to clebert.suconic)a new File Handler. reuse the same file though.
-
3. Re: LargeMessage deliver - https://jira.jboss.org/jira/brow
timfox Nov 2, 2009 8:22 AM (in response to clebert.suconic)I don't see how this is related to the journal.
-
4. Re: LargeMessage deliverer - https://jira.jboss.org/jira/br
clebert.suconic Nov 2, 2009 8:26 AM (in response to clebert.suconic)There are two implementations to LargeMessage:
http://anonsvn.jboss.org/repos/hornetq/trunk/src/main/org/hornetq/core/persistence/impl/nullpm/NullStorageLargeServerMessage.java
http://anonsvn.jboss.org/repos/hornetq/trunk/src/main/org/hornetq/core/persistence/impl/journal/JournalLargeServerMessage.java
When I said on Null Persistence, and on Journal, I was referring to those implementations individually.
the JournalLargeServerMessage is just the LargeMessage used when using the Journal. In fact it just uses a file. -
5. Re: LargeMessage deliverer - https://jira.jboss.org/jira/br
ataylor Nov 2, 2009 9:03 AM (in response to clebert.suconic)"clebert.suconic@jboss.com" wrote:
A simple fix, would be to create a method called cloneForDeliver on the LargeMessage interface, and use it on the ServerConsumer::LargeMessageDeliverer. This way we could reuse the same buffer on NullPersistence, and create a new file on Journal.
Thats similar to what i am doing. when large messages are encoded i pass round an encoding context, this context takes care of making a copy of SequentialFile (i.e. with a different file handle) and the large message encode method encodes using the context. Doing it this way i may be able to get rid of separate encode methods for normal messages and large messages, simplifying things.