You cannot call assertEquals() from different threads

[timfox]

I have just noticed that LargeMessageTestBase uses Junit assertEquals (or other asserts) inside a different thread to the thread that run the test, e.g.

E.g. the message handler class

MessageHandler handler = new MessageHandler()

calls assertEquals() in several places.

THIS WILL NOT WORK

assertXXX in Junit MUST be called from the main thread that ran the test. If it is called from other threads it will not cause the test to fail.

I just noticed that LargeMessageTest was passing but when I looked at the logs, several assertion failures were occurring.

Don't do this. It is VERY bad practice.

[clebert.suconic]

assertXXXX is just doing this:

if (!Condition) throw SomeThrowableException;


if I catch the Throwable and validate for exceptions on logs, that's the same thing.

I should be validating for the Throwables on those cases.. now if you see places where this is not happening, then there is an issue. I will double check I'm capturing the failures.

[timfox]

No, it doesn't work.

Like I say, assertions are logged in the logs but the test passes.

[clebert.suconic]

Those tests were supposed to do something like this:

public class Test extends TestCase
{

 class T extends Thread
 {
 Throwable t;

 public void run()
 {
 try
 {
 assertEquals(1, 2);
 }
 catch (Throwable e)
 {
 this.t = e;
 }
 }
 }

 public void testOne() throws Throwable
 {
 T thread = new T();

 thread.start();

 thread.join();

 if (thread.t != null)
 {
 throw thread.t;
 }
 }

}

If the test is not throwing the exception on the main thread, then there is a problem. Where do you see that? I need to fix it.