Shall I write up an issue (as a story card) for this?
Yes, definitely.
Alternatively, we could just use a single property (leaving room for other properties in the future)
arquillian-activation.properties
active.qualifiers=node1,node2
(or just "qualifiers")
I think I like that better.
I like that better as well. The only thing I'm missing are the rules how to autoactivate qualifiers in case arquillian-activation.properties is missing, which would be 95% of the cases.
@RunWith(Arquillian.class)
public class MethodSpecificDriverTestCase {
@Test
@InSequence(1)
// here we want to use <extension id="webdriver" qualifier="methodspecific" >
public void simpleWebdriverTest(@Drone @MethodSpecific FirefoxDriver webdriver) {
LoginPage page = new LoginPage(webdriver);
page.login("demo", "demo");
page.logout();
}
@Test
@InSequence(2)
// here we want to use <extension id="webdriver" >
public void simpleWebdriverChromeTest(@Drone ChromeDriver webdriver) {
LoginPage page = new LoginPage(webdriver);
page.login("demo", "demo");
page.logout();
}
}
Seems to me that qualifiers from arquillian-activation.properties does not match the story for extensions. We need to solve whether we want to prefer code over properties or the other way around.
Also, for multinode tests, suppose the following:
@RunWith(Arquillian.class)
public class ClusteredCacheTestCase
{
@Deployment(name = "dep.active-1")
@TargetsContainer("container.active-1")
public static WebArchive createTestDeployment()
{
return Deployments.createActiveClient("test-1.war");
}
@Deployment(name = "dep.active-2")
@TargetsContainer("container.active-2")
public static WebArchive createTestDeployment2()
{
return Deployments.createActiveClient("test-2.war");
}
@Deployment(name = "dep.active-3")
@TargetsContainer("container.active-3")
public static WebArchive createTestDeployment3()
{
return Deployments.createActiveClient("test-3.war");
}
@Inject
private Cache<String, Integer> cache;
@Test @InSequence(1) @OperateOnDeployment("dep.active-1")
public void callActive1() throws Exception
{
int count = incrementCache(cache);
System.out.println("Cache incremented, current count: " + count);
Assert.assertEquals(1, count);
}
@Test @InSequence(2) @OperateOnDeployment("dep.active-2")
public void callActive2() throws Exception
{
int count = incrementCache(cache);
System.out.println("Cache incremented, current count: " + count);
Assert.assertEquals(2, count);
}
What happens if you set arquillian.qualifiers="container.active-1,container.active-2" ? Will the test break?
IMHO, we could activate qualifiers only for non-qualified configuration used, given that qualifier matches the id.
<arquillian>
<container id="jboss-remote">
...
</container>
<container id="jboss-remote" qualifier="node1">
...
</container>
<container id="jboss-remote" qualifier="node2">
...
</container>
<container id="jboss-remote" qualifier="jenkinsas">
...
</container>
<extension id="webdriver">
</extension>
<extension id="webdriver" qualifier="ie10">
</extension>
<extension id="webdriver" qualifier="jenkinsbrowser">
</extension>
</arquillian>
So, by default tests will be using configuration without qualifiers where qualifier are not referenced in the code. This means active.qualifiers will have no way how to override node1, node2, ie10, because these are directly used in tests.
However, if you set active.qualifiers=jenkinsas,jenkinsbrowser, you'll get different browser for non-qualified Drones as well as different jboss-remote acting as default non-qualifier container. Obviously, given the arquillian.xml above, the only valid combinations will be:
- active.qualifiers= (default)
- active.qualifiers=any single qualifier
- active.qualifiers=node1,jenkinsbrowser
- active.qualifiers=node1,ie10
- active.qualifiers=node2,jenkinsbrowser
- active.qualifiers=node2,ie10
- active.qualifiers=jenkinsas,ie10
- active.qualifiers=jenkinsas,jenkinsbrowser (that's what users want to do on jenkins - note, they would likely create jenkins qualifier and share for both webdriver and jboss-remote unless running matrix jobs)
- active.qualifiers=node1,node2 <= not valid, what is default jboss-romote configuration then?
- active.qualifiers=jenkinsbrowser,ie10 <= not valid, what is default browser configuration then?
You got the point. How does this sound to you? Is this readable enough for users?
