3 Replies Latest reply on Mar 1, 2013 5:54 PM by clebert.suconic

HORNETQ-867 - setStringProperty() With null Value Does Not Work

diegolovison Feb 23, 2013 9:13 AM

I created an unit test for this issue, look the attachment.

Is it correct my unit test? All tested passed.

Thanks.

1. Re: HORNETQ-867 - setStringProperty() With null Value Does Not Work

clebert.suconic Feb 23, 2013 4:15 PM (in response to diegolovison)

What do you mean... the test is passing with or without your fix?

If you have a fix already you should probably send a PR.. the testcase seems to be doing what's supposed to!
Actions
2. Re: HORNETQ-867 - setStringProperty() With null Value Does Not Work

diegolovison Feb 28, 2013 7:43 PM (in response to clebert.suconic)

Without my fix. I getted the latest version from master, created the unit test and passed without an error. What do you think about that?
Actions
3. Re: HORNETQ-867 - setStringProperty() With null Value Does Not Work

clebert.suconic Mar 1, 2013 5:54 PM (in response to diegolovison)

You're right... I clsoed it...

but if you could add a check.. just in case?

Can you send a PR with the test change? there's never enough testing.
Actions