JSF sources for EAP 6.0.1 missing?

[henk53]

In the Maven repo for JBoss EAP 6.0.1 the source code is missing for the artifact jsf-impl-2.1.13-redhat-1. See http://maven.repository.redhat.com/techpreview/eap6/6.0.1/maven-repository/com/sun/faces/jsf-impl/2.1.13-redhat-1/

For the EAP 6.0.0 repo the source code is also missing, but for the EAP 6.1.Alpha1 one it's there (see http://maven.repository.redhat.com/techpreview/eap6/6.1.0.Alpha1/maven-repository/com/sun/faces/jsf-impl/2.1.18-jbossorg-1/).

Where can I find the source for jsf-impl-2.1.13-redhat-1.jar?

[ctomc]

Forked version of mojarra can be found at https://github.com/jboss/mojarra

see tags for specific versions https://github.com/jboss/mojarra/tags

in this case what you are looking for is 2.1.13-jbossorg-1

source is the same as with -redhat-1, just artifact stuffix is different.

--

tomaz

[henk53]

Tomaz Cerar wrote:

Forked version of mojarra can be found at https://github.com/jboss/mojarra

Thanks a lot, that's almost too easy

But as it seems, JBoss doesn't really modify the code at all? If I look at the only commit in each tag, nothing has really changed, e.g. https://github.com/jboss/mojarra/commit/32c4bdace57e66d2ac6237d0212f842fd8c79ea9

Everytime there's only the same change to the build.xml that does the splitting, and the different name for the final jar. In the EAP module folder I sometimes see that one EAP version (e.g. 6.0) has a -1 suffix, and then a later has a -4 suffix. Does that mean there have been actual changes? E.g. -1 is baseline "nothing changed" and then -4 is "stuff has changed"?

I manually diffed the sources for 2.1.18 (as they are in the 6.1.0.Alpha EAP repo), and I found 2 additional changes not found in github:

1. All line endings had been changed to Windows line-endings.
2. In the facelets package, the @version javadoc was modified by removing everything between the "id" identifier and the closing "$", as well as the final space.

Example for 2:

/**
 * 
 * @author Jacob Hookom
 * @version $Id: CompilationUnit.java 8641 2010-10-04 20:54:50Z edburns $
 */
class CompilationUnit {

Was changed into:

/**
 * 
 * @author Jacob Hookom
 * @version $Id$
 */
class CompilationUnit {

But I guess the (Maven) source packager must have been responsible for that.

Thanks again!

[ssilvert]

Usually when I do the -jboss version, there are three changes, none of which actually modify how the source code runs.  They are just associated with making a new version and splitting the impl jar from the api jar, as you noted.

However, sometimes we do add early versions of patches that are critical to JBoss.  Also, there might occasionally be a special one-off patch for a Red Hat customer.  This is what might sometimes account for the -1, -2, ... suffixes.  Also, it could just mean a build got messed up and needed to be re-released.

The API jar is actually built from here: https://github.com/jboss/jboss-jsf-api_spec.  But the source still comes from Mojarra.

I can't speak to how the -redhat version gets built.  I only do the -jboss version.

Stan