ConcurrentModificationException on Archive.delete()

[mathias.deshayes]

Hi,

I'm trying to use Shrinkwrap to delete a folder in a JavaArchive (jar). My jar is quite simple, it contains only one folder named resources and this folder contains two files :

myJavaArchive.jar:

/resources/

/resources/bar.txt

/resources/foo.txt

So I create a JavaArchive from my JAR file and I call delete method on "/resources" folder (see below) but it causes a ConcurrentModifictionException.

My code :

package com.test;
  
import java.io.File;
  
import org.jboss.shrinkwrap.api.ShrinkWrap;
import org.jboss.shrinkwrap.api.spec.JavaArchive;
  
public class Main {
    public static void main(String[] args) {
        JavaArchive archive = ShrinkWrap.createFromZipFile(JavaArchive.class,
                new File(Main.class.getResource("/myJavaArchive.jar").getFile()));
        System.out.println(archive.toString(true));
        archive.delete("/resources");
    }
}

The stack trace :

Exception in thread "main" java.util.ConcurrentModificationException

          at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793)

          at java.util.HashMap$KeyIterator.next(HashMap.java:828)

          at java.util.Collections$UnmodifiableCollection$1.next(Collections.java:1010)

          at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.removeNodeRecursively(MemoryMapArchiveBase.java:309)

          at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.delete(MemoryMapArchiveBase.java:291)

          at org.jboss.shrinkwrap.impl.base.MemoryMapArchiveBase.delete(MemoryMapArchiveBase.java:325)

          at org.jboss.shrinkwrap.impl.base.container.ContainerBase.delete(ContainerBase.java:393)

          at com.test.Main.main(Main.java:13)

Shrinkwrap version : 1.1.2

jdk : tested on 1.6 and 1.7

[alrubinger]

I'll bet MemoryMapArchiveBase.removeNodeRecursively is removing a Node while still inside of an iteration.

Michal is opening a JIRA for it; thanks for the report.

[alrubinger]

https://issues.jboss.org/browse/SHRINKWRAP-455

[mathias.deshayes]

Thanks Andrew.

I "manually" delete children before deleting the resources folder for the moment and it works.

[smikloso]

Hi,

I would like to know if I am safe to use ShrinkWrap 1.1.3 in connection with Arquillian core 1.1.0.Final since this release of Arquillian uses ShrinkWrap 1.1.2 where this issue is not resolved (it is done in 1.1.3 AFAIK), right?

What is the best practice here? Should I use ShrinkWrap 1.1.3 and override dependencies of Arquillian Core or is there some workaround how to do this in the code?

[mmatloka]

Hi,

Yes, issue is resolved in 1.1.3. It would be the best to use ShrinkWrap 1.1.3 with Arquillian 1.1.0.Final simply by overriding via dependency management (shrinkwrap dep management before arquillian in pom).

[alrubinger]

Note: Make sure you put the shrinkwrap-bom artifact in dependencyManagement in "import" scope to ensure that all modules get the versions overridden correctly

[kpiwko]

Also make sure that you place shrinkwrap-bom before arquillian-bom or jboss-javaee-6.0-with-tools BOM in <dependencyManagement>