PickList and OrderingList added to RichFaces Widgets

[bleathem]

I ported the orderingList and pickList from the bootstrap sandbox project to the richfaces-widgets standalone JavaScript project.  The port was non-trivial, as it required a Bootstrap v3 update.

What a great infrastructure you've setup Paul, the rapid turnaround on widget development is superb!

A couple of observations as a reault of working with the new widget repo:

1) We don't need to copy the jQuery source into the src tree.  I added jQuery-UI to bower and referenced it in the component folder from the example.  Similarly true for the fontawesome files.  In fact, it's counter-intuitive to copy them in this way, as it makes you think you can edit them.  I ran into this when correcting the fontawesome font path.

2) If we are going to use the example for component development, it shouldn't use the dist resources, these are compressed and uglified.  Rather we should include the raw uncompressed/un-concatenated JavaScript files.  Perhaps the example itself could undergo some "dist" process whereby it picks up the compressed resources.

I look forward to highlighting this effort next week in my JAX talk!  Nice work Paul!

Brian

[lfryc]

Great to hear your experience, Brian.

Brian Leathem wrote:

2) If we are going to use the example for component development, it shouldn't use the dist resources, these are compressed and uglified.  Rather we should include the raw uncompressed/un-concatenated JavaScript files.  Perhaps the example itself could undergo some "dist" process whereby it picks up the compressed resources.

Those examples should reference to uncompressed versions, but during distribution packaging, they should be rewritten to reference to dist.

We can use concat -> cssmin / htmlmin / imagemin / jsmin -> usemin grunt tasks for this.

The usemin tasks overwrites all references to use minified versions.

Brian Leathem wrote:

1) We don't need to copy the jQuery source into the src tree.  I added jQuery-UI to bower and referenced it in the component folder from the example.  Similarly true for the fontawesome files.  In fact, it's counter-intuitive to copy them in this way, as it makes you think you can edit them.  I ran into this when correcting the fontawesome font path.

Brian

I'm pretty sure we will find most of our third-party dependencies in Bower repositories.

[lfryc]

I can see place for improvent in this part where Bower-retrieved resources are copied from components to a source tree:

https://github.com/richfaces/richfaces-widgets/blob/b04f54fd967e3cd2b2dca79f4e4fa1317fffe6fb/Gruntfile.js#L186

The only information what should be needed is what/where?

[
    { what: "components/font-awesome/build/assets/font-awesome/font/*", where: "fonts/fontawesome" },
   { what: "components/font-awesome/build/assets/font-awesome/less/*.less", where: "styles/fontawesome" },
    ...
]

[lfryc]

Hmm it reminds me - where we are going to track richfaces-widgets issues?

Can we use GitHub issue tracker at this point? I consider it much more agile than using JIRA at this point.

[lfryc]

I have moved forward and created some issues, we can discuss there:

https://github.com/richfaces/richfaces-widgets/issues

[bleathem]

To be clear, I am saying the bower retrieved resources should not be copied into the source tree at all.  We should develop against them in the components folder, and move them into dist when we build.

+1 for github issues.

[paul.dijou]

Glad you like it! I will try to improve it as we discussed on irc (and update Gruntfile since both regarde and livereload have been deprecated in favor of watch). I'm so excited about seeing this project taking off. For the rest, already answered on related GitHub issues.