LocalManagedConnectionFactory#matchManagedConnections performance

[janssk77]

HI,

I'm using jboss 7 with a plain old oracle datasource. (pool of 200 connections, all with the same username/password)

Profiling shows that a lot of time is spent in the above method. It for instance calls a synchronized method (getConnectionProperties), which is problematic in a parallel environment.

Knowing that my datasource only contains 'matching' connections, i wonder whether there is a way of skipping the properties comparision step.

Any ideas ?

Thanks,

Koen

[jesper.pedersen]

First of all - you should use WildFly 8 Alpha1

And, precisely the database you are using is the reason the check is in place. It changes the passed in properties object.

However, you havn't posted your configuration nor profiling data, so maybe you aren't using an optimal configuration for your case. Lets see it.

And, we welcome any patches that improves this scenario.

[janssk77]

Isn't the matching only useful in scenarios where the same pool stores 'different' DB connections (differnet username/pswd) ?

I suspect that jboss 7 'blocks' (in synchronised calls) a lot more than jboss 5 did during pooling. The 'matchManagedConnections' is one occurence. Another one is org.jboss.jca.core.connectionmanager.pool.mcp.SemaphoreArrayListManagedConnectionPool#getConnection.

Anyway, i'll try do some more testing/measuring tomorrow.

[jesper.pedersen]

Not if the database changes the objects we pass in...

The JDBC resource adapter is almost the same as was included in 3/4/5/6.

Yeah, do that...