SOAPFault with HTTP 200 response code

[jbride]

Hi,

  in some situations, switchyard returns a SOAPFault message using an HTTP 200 response code

the problem can be reproduced in the latest master branch using the soap-binding-rpc quickstart.

this problem is specific to RPC/Literal ...... all is well with DOC/LIT.

to reproduce the problem, build and deploy the soap-binding-rpc quickstart and send to the SOAP service a soap message with an incorrect namespace.

ie:    intentionally change the namespace of the SOAP message to:    rn:switchyard-quickstart:external:1.0    (drop the initial 'u' )

org.switchyard.component.soap.InboundHandler.assertComposedMessageOK( ....  )   correctly identifies the problem and throws a SOAPException

subsequently, the response back to the client is the correct SOAPFault message however it is returning using an HTTP 200 response code.

Interestingly, scenarios using the same quickstart that throw a SwitchyardException (ie:  sending the SOAP message with correct namespace but with a null "day" field) route through a different error handling path where the SOAPFault message is correctly returned using an HTTP 500 response code

thank you.   Jeff

[mageshbk]

Hi Jeff,

Did this work before or are you noticing it for the first time?

regards,

Magesh

[jbride]

Hi Magesh.

   the same problem does occur in SY 0.8* 

   i mention use of the latest master branch because the soap-binding-rpc quickstart (so as to demonstrate the problem) is only available in the master branch.

thank you!  jeff

[mageshbk]

Thansk Jeff! I will have a look at this first thing in my morning.

[mageshbk]

Hi Jeff,

Sorry, I got caught up in my other task. I first thought I could not simulate this issue. Then I realized this happens only in CXF in AS7 server. The satandalone JDK returns correct response code. I will chase it up with the WS team and let you know.

regards,

Magesh

[mageshbk]

Okay, in our SOAP gateway when it creates Fault, CXF thinks that these are not Exceptions and just pass the response as 200. Now should the stack detect the SOAPFault and send a 500 status code or not, is a debate for another day. We have now the facility to update status code as needed and we should be setting 500 for SOAPFaults, irrespective of the stack used. I will set this as part of my MTOM fix that I am working right now.

The Doc/lit case worked because, fortunately CXF has an Interceptor for such cases, where it checks the validity of the request.

[jbride]

excellent.  thank you Magesh

[jbride]

thanks Magesh.  just confirmed this has been fixed in the master branch.