weakreference will be reference while retrieve from JCR

[angelo.chen]

When i save a property use

     node.setProperty(name, value, type); if the type is weakreference while i retrieve it from jcr, it will be reference. Is it a bug?

After investigate the code,

Found class JcrValue treat the weakreferce and reference the same while persist.

L294 miss PropertyType.WeakReference case

L495

            case PropertyType.REFERENCE:

            case PropertyType.WEAKREFERENCE:

                return factories().getReferenceFactory().create(value.getString());

L529

            case PropertyType.REFERENCE:

            case PropertyType.WEAKREFERENCE:

                return factories().getReferenceFactory().create(value);

[rhauch]

What version of ModeShape are you using? If I look at version 3.4.0.Final, then JcrValue does have the incorrect behavior. However, this was fixed in ModeShape 3.5.0.Final; see the source code.

Please try this with ModeShape 3.5 and let us know what you find.

[angelo.chen]

Thanks. I am using version 3.3.0.Final of ModeShape.

[rhauch]

We already know that this is a problem in 3.3.0.Final, but was fixed in 3.4.0.Final.