mod_proxy_cluster.c:3325: possible bad if test ?

[dcb314]

I just compiled mod_cluster-1.2.6 with Linux gcc flag -Wlogical-op and it said

mod_proxy_cluster.c:3325:17: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

               while (*path !='&' || *path !='\0')

Suggest swap || for &&

[jfclere]

sure create a JIRA and provide a patch. Actually removing the sessionid is not used often.

[rhusar]

Correct me if I am wrong, but that would actually result in a segfault?

while(*path!='&'||*path!='\0')

path++;

[dcb314]

>Correct me if I am wrong, but that would actually result in a segfault?

I think so. The while loop cannot finish, so it runs

until it reaches an invalid address and then segfaults.

It also looks as if there needs to be an additional test case in

the test suite to cover this code.

[rhusar]

If I am roughly reading that this logic can be triggered:

* HTTPd version higher than 2.3.11

* selecting a worker for failover to a different domain

* sticky-session-force OFF

* sticky-session-remove ON

Which is not exercised very frequently.

David, so please Jira and see if you can attach a test code as well. Thanks!

[rhusar]

[MODCLUSTER-373] [mod_cluster] - mod_proxy_cluster.c:3325: possible bad if test ? - JBoss Issue Tracker