DataSource injected into SFSB does not serialize properly

[pferraro]

The JIRA WFLY-30, with the title "@Resource injection of Datasource on clustered SFSB fails with serialization error" was reclassified as a JBJCA issue: [JBJCA-1112] DataSource marked as Serializable - JBoss Issue Tracker

A fix was made to 1.1.2.Final, but the original WFLY-30 issue was not addressed - though it now appears to fail for different reasons.  In the future, I would recommend opening a new upstream issue and link the two, rather than reclassify, re-title, and lose the context of the original issue.

I've reopened JBJCA-1112/WFLY-30.  Here's the current error:

SFSB w/injected DataSource serialization error

There is a test case in the clustering testsuite that you can use to reproduce the error:

wildfly/testsuite/integration/clust/src/test/java/org/jboss/as/test/clustering/cluster/ejb/stateful/StatefulFailoverTest…

This test case attempts to serialize the following SFSB:

wildfly/testsuite/integration/clust/src/test/java/org/jboss/as/test/clustering/cluster/ejb/stateful/bean/ResourceManager…

[jesper.pedersen]

The DataSource now implements the private contract of the Serializable interface -

private void writeObject(java.io.ObjectOutputStream out)
     throws IOException
 private void readObject(java.io.ObjectInputStream in)
     throws IOException, ClassNotFoundException;
 private void readObjectNoData()
     throws ObjectStreamException;

Are you sure those methods are invoked of that call stack ?

[jesper.pedersen]

IronJacamar test case for the issue is: https://github.com/ironjacamar/ironjacamar/blob/1.1/adapters/src/test/java/org/jboss/jca/adapters/jdbc/unit/SerializableTestCase.java

[pferraro]

I've added some debug code to my test case, and it seems that your serialization logic is not compatible with JBoss Marshalling.  JBM requires that custom writeObject(...) and readObject(...) methods must properly call out.defaultWriteObject() and in.defaultReadObject(), respectively, before manipulating the stream.

I've submitted a PR to fix that:

Ensure serialization logic is compatible with JBoss Marshalling by pferraro · Pull Request #102 · ironjacamar/ironjacama…

With these changes, the DataSource can now serialize and deserialize correctly via JBoss Marshalling.

However, your deserialization logic assumes that the DataSource will be deserialized in the same JVM instance from which it was serialized.  This assumption does not hold true in a cluster, nor even in a single server environment, where an SFSB is passivated on shutdown and re-activated on restart.  Some other solution is needed.

[jesper.pedersen]

Yeah, on second thought it is a bad solution, so I'm going to revert.

The only option is to do the full solution, which is a non-trivial implementation of the current IronJacamar container.