SavedRequest causes NotSerializableException in clustered mode

[faxe13]

Hi,

I am using wildfly CR1 in standalone-full-ha mode where the web sessions will be distributed across the cluster nodes. I am also using FORM based authentication in my application. One thing I have noticed is that when users that are not authenticated send a POST request to the server they get redirected to the login page as expected but during this operation I see exceptions in the loggfiles like this:

2014-01-21 15:11:22,960 ERROR [org.infinispan.interceptors.InvocationContextInterceptor] (default task-2) ISPN000136: Execution error: org.infinispan.commons.CacheException: java.lang.RuntimeException: Failure to marshal argument(s)

        at org.infinispan.commons.util.Util.rewrapAsCacheException(Util.java:581)

        .......

        .......

Caused by: org.infinispan.commons.marshall.NotSerializableException: io.undertow.servlet.util.SavedRequest

Caused by: an exception which occurred:

        in object java.util.HashMap@9bc848a8

        in object org.jboss.as.clustering.marshalling.SimpleMarshalledValue@9bc848a8

        in object org.infinispan.commands.write.PutKeyValueCommand@899e95ca

        in object org.infinispan.commands.tx.PrepareCommand@e338a19d

After a bit of debugging I found the reason for that. The ServletFormAuthenticationMechanism.storeInitialLocation() method that is called when the FORM based authentication mechanism kicks in tries to store the current request by calling SavedRequest.trySaveRequest(exchange). In this method the current request is stored inside the current session. GET requests wont trigger the session.setAttribute(SESSION_KEY, request) but POST requests do because exchange.isRequestComplete() is true for GET but not for POST requests. Because the SavedRequest is not Serializable infinispan cannot marshall the session any more to distribute is across all the cluster nodes.

I see two  solutions for this issue:

1) Try to make the SavedRequest class Serializable.

2) Store the SavedRequets in the LocalSessionContext in org.wildfly.clustering.web.undertow.session.SessionAdapter.setAttribute() just like it is done for the AUTHENTICATED_SESSION_ATTRIBUTE_NAME to prevent the SavedRequest from being distributed to other cluster nodes.

I am curious what you think about this issue. For now I would like to set the UndertowOptions.MAX_BUFFERED_REQUEST_SIZE to 0 to disable this feature but I could not find a way to do that because the wildfly standalone config does not expose a way to set this property in the xml.

Cheers, Gert

[rhusar]

Please try with upstream master branch

https://github.com/wildfly/wildfly

wildfly/wildfly · GitHub

since 3d644f047f71070d6a054c3ba129350d01069b38 fixes the lost indentity on failover.

[faxe13]

Hi Radoslav,

Thanks for the quick answer. I am sorry for the bad explenation of my current issue but I am sure it has nothing to do with the commit 3d644f047f71070d6a054c3ba129350d01069b38 which is about something completely different namely "WFLY-2704 FORM authenticated identity lost on failover" which was also posted by me in Clustering with CachedAuthenticatedSessionMechanism but got fixed in the meantime by Paul Ferraro. I have checked that is works about 2 weeks ago.

My current issue is about the fact that the ServletFormAuthenticationMechanism.storeInitialLocation() method stores an object into the HTTP session that is not Serializable and that causes problems in cases where sessions get clustered across all cluster nodes as you can see in the exception stack of my previous post. The object is an instance of io.undertow.servlet.util.SavedRequest.

Can you verify that this is a problem in the undertow code or is there a configuration that I did not find that would help me out ?

Cheers, Gert

[ctomc]

Hey,

This is a bug, can you create jira entry for it Undertow - JBoss Issue Tracker

--

tomaz

[faxe13]

Hi,

I have created UNDERTOW-176 which was immediately resolven by Stuart Douglas without any comment.

So I don't really know what the status of this issue is right kow.

Cheers, Gert

[rhusar]

Hi Gert,

thanks for the report. If you look at the metadata of that resolution, it was fixed in Undertow in Beta33. Currently WildFly master is using Beta30, so the issue is not fixed there. It will be fixed in the next Undertow upgrade coming very soon (you may want to try upgrade yourself and retest).

As you have noticed the components are rapidly changing and evolving, so apologies if things are not sugar-coated but we very much appreciate your feedback!

PS: Fixed by Make SavedRequest serializable · 0d6a048 · undertow-io/undertow · GitHub

Rado

[faxe13]

Excellent

I cloned the untertow master this morning to check the state of the class before submitting the post. At that time the class still not not Serializable :-). Anyway thanks for the quick response. I really appreciate your work and hope that I will be able to give some more feedback in the future.

Gert

[ctomc]

Undertow beta33 component update was just merged to wildfly master.

so if you pull latest changes and build it you can try if it fixes the problem for you.

[faxe13]

Hi,

I have checked the wildfly git master with the Beta 33 version of undertow and did not find any errors any more.

Thanks for fixing this issue.

Gert