WeldClientProxy and protected methods

[simon.kulessa]

I have recently updated our JSF (Trinidad) webapp from weld 1.1.8.Final to 2.1.2.Final.

Now while starting the UI I get the following exception:

org.apache.jasper.el.JspPropertyNotFoundException: ... '#{testBean.dataTable}' Property 'dataTable' not readable on type test.TestBean$Proxy$_$$_WeldClientProxy

    at org.apache.jasper.el.JspValueExpression.getValue(JspValueExpression.java:109)

    at com.sun.faces.application.ApplicationImpl.createComponentApplyAnnotations(ApplicationImpl.java:1941)

    at com.sun.faces.application.ApplicationImpl.createComponent(ApplicationImpl.java:447)

    at org.jboss.weld.environment.servlet.jsf.ForwardingApplication.createComponent(ForwardingApplication.java:113)

    at javax.faces.webapp.UIComponentELTag.createComponent(UIComponentELTag.java:222)

    at org.apache.myfaces.trinidad.webapp.UIXComponentELTag.createComponent(UIXComponentELTag.java:223)

    at javax.faces.webapp.UIComponentClassicTagBase.createChild(UIComponentClassicTagBase.java:506)

    at javax.faces.webapp.UIComponentClassicTagBase.findComponent(UIComponentClassicTagBase.java:744)

    at javax.faces.webapp.UIComponentClassicTagBase.doStartTag(UIComponentClassicTagBase.java:1311)

The problem seems to be that the getDataTable Method is protected, if I put the access level to public it seems to work fine.

Is this a bug in the newer version?

I did not find anything in the weld-documentation that protected methods are not supposed to be injectable on a proxy object.

[mkouba]

Hi Simon,

I don't think this is a Weld issue. In your EL expression #{testBean.dataTable}, dataTable should be theoretically resolved by javax.el.BeanELResolver which only discovers public JavaBean properties. Is Weld the only component you upgraded?

[simon.kulessa]

Hi Martin,

I did some other upgrades before, but after this point everything was working fine.

Then I continued with upgrading Weld and got into this problem.

[mkouba]

You're right. It seems all the proxy methods are public in Weld 1.1.x. I'm not sure whether it's a bug or a "feature" though. I will investigate this further.

[mkouba]

It's likely a bug in Weld 1.1.x - I created a new issue WELD-1626. In any case, it's definitely a bad idea to allow access of protected methods via EL expressions.

[simon.kulessa]

Hi Martin,

thanks for your answer.

Maybe you (someone else?) could also trigger an update of the documentation that only public methods should be used.

[mkouba]

Maybe you (someone else?) could also trigger an update of the documentation that only public methods should be used.

Well, the CDI programming model does not forbid protected methods (e.g. you can have a protected observer method). Of course there are some limitations for client proxies etc... However Unified EL only supports JavaBean properties out of the box (see also http://docs.oracle.com/cd/E19226-01/820-7627/bnahu/index.html). The CDI container must only provide an ELResolver that resolves bean names and returns contextual instances (bean instance). Properties are handled by standard EL resolver chain.