Impossible to use BusinessCalendar and Date type deadlines together

[b.r]

I'm not sure if this is intentional but when there is a BussinesCalendar (even default implementation) set in Environment it is not possible to use Date type deadlines. Problematic code in StateBasedNodeInstance.createTimerInstance (jbpm 6.0.1.Final):

if (kruntime != null && kruntime.getEnvironment().get("jbpm.business.calendar") != null){
            BusinessCalendar businessCalendar = (BusinessCalendar) kruntime.getEnvironment().get("jbpm.business.calendar");
            
            String delay = resolveVariable(timer.getDelay());
            
            timerInstance.setDelay(businessCalendar.calculateBusinessTimeAsDuration(delay));
            
            if (timer.getPeriod() == null) {
                timerInstance.setPeriod(0);
            } else {
                String period = resolveVariable(timer.getPeriod());
                timerInstance.setPeriod(businessCalendar.calculateBusinessTimeAsDuration(period));
            }
        } else {
            configureTimerInstance(timer, timerInstance);
        }

Example deadline definition:

 <Deadline Execution="SYNCHR" Type="DATE">
      <DeadlineDuration>#{DATE}</DeadlineDuration>
      <ExceptionName>Wybudzenie1</ExceptionName>
</Deadline>

Date type deadline has both delay and period set to null so when one is passed here it ends with NullPointerException in method that resolves delay. Besides when calendar is set date is never being checked. Is usage of this type of deadlines not supported with calendars?

[swiderski.maciej]

it certainly should be supported so if you could provide bpmn2 that you use to reproduce the issue then we'll look into it and fix it.

HTH

[b.r]

Example bpm2 in attachement. To reproduce error there has to be BusinessCalendar set in environment in time of execution.

[b.r]

Any updates? For now we are using custom version of jbpm with condition changed to if(kruntime != null && kruntime.getEnvironment().get("jbpm.business.calendar") != null && timer.getTimeType()!=Timer.TIME_DATE) but we would like to be able to use official release when 6.1.0 comes out.

[swiderski.maciej]

thanks for reminder, will look into it today

[swiderski.maciej]

fix applied for both master and 6.1.x branch as part of this jira so it will be included in 6.1.0.Final thanks for reporting.

HTH