Source code to pax-logging-api and pax-logging-service

[ark_adius]

Hi,

I'm using FuseESB v 4.3.1. I found out that there is other jar version of package pax-logging-* than official 1.6.2. Looking to decompiled code I found out that in org.apache.log4j.Category there is used monitor-based synchronization instead of ReentrantReadWriterLock (like in official version).

Can you tell me, where can I found source code or what is real version of that library used in distribution?

Regards,

Arek

[ffang]

Hi,

Please tell us what exactly FUSE ESB version you're using.

The pax-logging used in FUSE ESB 4.3.1 series varies, for example, FUSE ESB 4.3.1-fuse-00-00 use pax-logging 1.5.3, FUSE ESB  4.3.1-fuse-02-05 use pax-logging 1.6.2, but they're all from pax-logging official release AFAIK.

Freeman

[ark_adius]

I'm using version: 4.3.1-fuse-03-01

Ok, I've checked out that on https://oss.sonatype.org/content/repositories/ there is the same, 1.6.2 version binary. But this official release was not build using code from: https://github.com/ops4j/org.ops4j.pax.logging

In tag logging-1.6.2 there is in sources at pax-logging-service/src/main/java/org/apache/log4j/Category.java:

    public void callAppenders(LoggingEvent event) {

        int writes = 0;

        for (Category c = this; c != null; c = c.parent) {

            // Protected against simultaneous call to addAppender, removeAppender,...

            c.lock.readLock().lock();

(...)

And in decompiled binary used in fuse there is:

c = this;

(..)

{

if(c == null)

break; /* Loop/switch isn't completed */

synchronized(c)

So it looks like this bug http://team.ops4j.org/browse/PAXLOGGING-122 wasn't resolved in this version.

Arek

[ffang]

Hi,

Do you mean PAXLOGGING-122? PAXLOGGING-122 get fixed by on Dec 15,2011, but pax-logging 1.6.2 get released on April 28, 2011, so pax-logging 1.6.2 definitely won't have this fix, pax-logging 1.6.4 should have this fix. Btw, this fix only changed

pax-logging-service/src/main/java/org/apache/log4j/OsgiThrowableRenderer.java, it has nothing to do with the  Category.java you mentioned here.

https://github.com/ops4j/org.ops4j.pax.logging/commit/395c4601bba2f9acd571bffa928c79b5f508038a

Freeman