NullPointerException on unit test advice due to wrong blueprint context.

[murray.hughes]

fuse-esb-7.0.0.fuse-061.

Have a unit test using CamelBlueprintTestSupport, attempting to advise amq endpoints with mock/direct endpoints.

     @Override

     public void setUp() throws Exception {

          super.setUp();

          System.err.println("context=" + context.getRouteDefinitions());

          context.getRouteDefinition("MyRoute").adviceWith(context,

          new AdviceWithRouteBuilder() {

               @Override

               public void configure() throws Exception {

                    weaveById("Queue").replace().to("mock:Queue");

               }

          });

I found that context.getRouteDefinition(route) was returning null.

Further investigation showed that CamelBlueprintTestSupport.context refered to the wrong context.

I had used this in the unit test.

    protected String getBlueprintDescriptor() {

        return "/OSGI-INF/blueprint/blueprint.xml";

    }

Changing the xml file name didn't avoid the problem.

It appears that the root cause is that CamelBluePrintHelper.getOsgiService is getting called without a filter.

I attempted to add this to my unit test:

     @Override

     protected String getBundleFilter() {

          return "(Bundle-SymbolicName = MyTest)";

     }

I tried the Unit test class name (MyTest) because that appeared in the debug log.

but obvously that's not right because when I tried this it found no context.

The only workaround I found that worked was to move the maven dependency of the offending context to the end of the dependencies.

A possible enhancement is to CamelBlueprintTestSupport is to pass CamelBluePrintHelper.getOsgiService a filter by default to ensure the correct context is selected.

It would be good to know what to return from getBundleFilter() to ensure my unit test's context is selected?

[njiang]

Hi,

Did you try to add the filter parameter by override the createCamelcontext() method of CamelBuleprintTestSupport.

I'm not sure if there are other bundles which have blueprint configuration files can cause the trouble that you have.

BTW, it could be more easy for us to trace the issue if you can provide a simple test case.

Willem

[murray.hughes]

I did try this in mu unit test:

@Override

protected CamelContext createCamelContext() throws Exception {

   return this.getOsgiService(CamelContext.class, "(Bundle-SymbolicName=MyTest)");

}

It causes a different problem:  it does not find my context. I'm unsure if MyTest(the unit test class name) is correct.

Yes there are other bundles which have blueprint configuration files in my dependencies.   It is one of those which is getting picked.  I included those to get access to the pojo classes being passed via jms.

I suspect its caused by this code in CamelBlueprintTestSupport:

    @Override

    protected CamelContext createCamelContext() throws Exception {

        return CamelBlueprintHelper.getOsgiService(bundleContext, CamelContext.class);

    }

Furthermore, I find the problem is intermittant.  Sometimes the test passes, sometime its gets the NPE described here, with no change to code.  I suspect its a race.

It'll be a fair bit of work to create a test case because I'll have to reproduce the timing(which I don't understand).  I'll see what can be done.

[murray.hughes]

Both bundles have the same package.  maybe that's contributing to the problem.

[ffang]

Hi,

Yeah, same packages across bundles is a so called "split package" issue in OSGi world, you definitely should avoid it.

Freeman

[murray.hughes]

Since applying the solution for another problem: http://fusesource.com/forums/message.jspa?messageID=14911#14911

this problem has stopped happening.