Export / Import and CR / LF / CRLF

[dev_java]

hello modeshape team!

as recommended in MODE-2306 i've implemented a backup & restore functionality. that worked quite well but there is a problem with properties where the stored data contains newline characters.

The newlines get written to the exported JSON directly as for example CRLF. This makes the export file no longer readable for the import, it simply stopps importing when encountering such newline characters and only performs a partial (most of the time corrupted) import. is this something you could handle better on the export / import side or do we have to escape these characters when saving a node to the repository?

thanks in advance!

[rhauch]

Please log an issue as soon as possible. We're about to release a 3.8.1.Final release and 4.0.0.Beta2. We may not be able to get the fix into Beta2, but we certainly would get it into the 4.0.0.Final.

UPDATE: Also, please be sure to give a test case that replicates this. We don't want to create a test case that's slightly different and doesn't quite fix your problem. Really, coming up with a test case should be easy; see https://github.com/ModeShape/modeshape/blob/master/modeshape-jcr/src/test/java/org/modeshape/jcr/RepositoryBackupTest.java and https://github.com/ModeShape/modeshape/blob/master/modeshape-jcr/src/test/java/org/modeshape/jcr/RepositoryRestoreTest.java for some examples, and it sounds like you just need to make sure the repository that's backed up has the content you describe. BTW, the test case should be able to backup from 3.x and restore to a new 3.x repository -- I don't think the 4.0 restore functionality is any different than in 3.x.

[dev_java]

Hi Randall,

i opened a new issue: MODE-2309

[rhauch]

Thanks! Please include a test case or at the very least some sample content that we can use in one of our existing backup & restore test cases. See above for reasons.

[dev_java]

Hi Randall,

i've put together a reproduction example and an broken output file and attached them to the ticket.