Nested collapsibleSubTable BUG with RichFaces 4.5.0.Final

[cooper_lyt]

I do have 3 levels of collapsibleSubTable nesting, but i click collapse link only collapse ten row!

my bean:

public class TestKnow {

    public List<TopLevel> getTopLevelDatas(){
        List<TopLevel> result = new ArrayList<TopLevel>(1);
        result.add(new TopLevel());
        return result;
    }

    public static class TopLevel {

        private String title;

        private List<SecondLevel> secondLevels = new ArrayList<SecondLevel>(1);

        public TopLevel() {
            this.title = "test Top level";
            secondLevels.add(new SecondLevel("test second Level"));
        }

        // geter and seter ...          
    }

    public static class SecondLevel {
        private String title;

        private List<String> thirdLevels = new ArrayList<String>(15);

        public SecondLevel(String title) {
            this.title = title;
            for (int i = 0; i < 15; i++) {
                thirdLevels.add(String.valueOf(i));
            }
        }
        // geter and seter ...                
    }
}

my page:

        <r:dataTable value="#{testKnow.topLevelDatas}" var="_topLevel">

            <r:column>
                <r:collapsibleSubTableToggler for="sbtb2"/>
                <h:outputText value="#{_topLevel.title}"/>
            </r:column>

            <r:collapsibleSubTable id="sbtb2" value="#{_topLevel.secondLevels}" var="_sencondLevel">

                <r:column>
                    <r:collapsibleSubTableToggler for="sbtb3"/>
                    <h:outputText value="#{_sencondLevel.title}"/>
                </r:column>

                <r:collapsibleSubTable id="sbtb3" value="#{_sencondLevel.thirdLevels}" var="_thirdLevel">
                    <r:column>
                        <h:outputText value="#{_thirdLevel}"/>
                    </r:column>
                </r:collapsibleSubTable>

            </r:collapsibleSubTable>
        </r:dataTable>

display:

expand:

collapse:

any idea?

[cooper_lyt]

i found this Bug  in richfaces-4.5.0.Final.jar/resources/org.richfaces/collapsible-subtable.js

        var element = function() {
            if (! this.isNested) {
                //use parent tbody as parent dom elem
                return $(document.getElementById(this.id)).parent();
            } else {
                var regex = new RegExp(this.id + "\\:\\d\\:b");
                return $(document.getElementById(this.id)).parent().find("tr").filter(function() {
                    return this.id.match(regex);
                });
            }
        };

var regex = new RegExp(this.id + "\\:\\d\\:b");  // ten row id is  :"j_idt61:0:sbtb2:0:sbtb3:10:b" so  not match !!!!!!!

change to :

var regex = new RegExp(this.id + "\\:\\d+\\:b");

Solve

[michpetrov]

Hi,

given that you've found the solution could you submit a pull request to github.com/richfaces/richfaces?

[cooper_lyt]

pull request Created

[michpetrov]

Thanks. I'll need you to do one more thing - sing the CLA, then we can accept the pull request.

[cooper_lyt]

Not at all. It's my pleasure.  singed