No DefinitionException when missing @Inject on decorator constructor

[tomwright]

The spec states in 8.1.2: "A decorator must have exactly one delegate injection point. If a decorator ... does not have a delegate injection point, the container automatically detects the problem and treats it as a definition error."

I'm having a problem where the code below, missing @Inject on the constructor, isn't causing a DefinitionException, it's just silently not being picked up as a decorator. If I instead use a field injection point and forget the @Inject, then I do get a DefinitionException:

org.jboss.weld.exceptions.DefinitionException: WELD-000059: No delegate injection points defined for [EnhancedAnnotatedTypeImpl] public @Priority @Decorator class com.misc.MyDecorator

@Decorator
@Priority(10)
public abstract class MyDecorator implements MyInterface {

    // Doing this instead behaves correctly
    // @Any
    // @Delegate
    // Bean bean;

    // missing @Inject
    public MyDecorator(@Delegate @Any MyInterface decoratedBean) {
    }

    @Override
    public String getString() {
        return "String";
    }
}

Any idea what's going on here? Is this a bug in Weld?

Thanks for any help

[tremes]

Hi Tom,

Well it really looks like a bug. Good catch. I created https://issues.jboss.org/browse/WELD-1811

Thank's

[mkouba]

Hi Tom and Tom,

the problem is the decorator is also a managed bean (8.1. Decorator beans). MyDecorator from the example is ignored because it does not have an appropriate constructor (3.1.1. Which Java classes are managed beans). So in my opinion we shouldn't throw a DefinitionException but it would be useful to log a warning message...

[tomwright]

That makes sense. Yes, a warning message seems like the most sensible solution. Thanks to both of you