[jaikiran]

It looks like, on faster computers,

Greg, please also post your machine configurations (CPU cores etc..). I'm pretty sure it's triggering a bug related to (missing) service dependencies.

[jaikiran]

I had one more look at the HornetQ and WildFly code today and I think the issues that you are seeing are all a result of this bug [WFLY-4751] JNDI lookups of JMS topics/queues can lead to null return values due to a missing service dependency - JBoss…

I've submitted a pull request containing the fix Fix for WFLY-4751 by jaikiran · Pull Request #7583 · wildfly/wildfly · GitHub. It needs a review from the messaging team since I've no way of reproducing this (at least not easily) or verifying that the fix will indeed solve your issues. I do think it should. So if you know how to build from source or are willing to build from source with this patch included and test out your application, let us know. If that's not possible then please try and continue to come up with a reproducible application (along with the details about your machine specs) so that someone can at least try it out against this commit (provided the messaging team accepts the PR), before 9.0.0.CR2 gets released.

[jewellgm]

We have a lot of lower-end systems at my company because that's what are software is targeted for.  About the most powerful system we have to test with has a Core i7-2720QM CPU with 8GB RAM.  On this system, we have the timing issue with JMS about 9 times out of 10.

I don't immediately know how to build WildFly from source, but it is something that I would be willing to try once it's able to be tested.  If you could point me to a location that describes the process to do this, I would appreciate it.

[jaikiran]

Greg Jewell wrote:

I don't immediately know how to build WildFly from source, but it is something that I would be willing to try once it's able to be tested.  If you could point me to a location that describes the process to do this, I would appreciate it.

Most of it is explained here Hacking on WildFly with the context that someone wants to contribute to the source. So many of those steps won't be relevant for someone who just wants to build it.

To build the code, you should be able to do the following:

# Clone the repo
git clone https://github.com/wildfly/wildfly.git

# cd to the directory of the cloned repo
cd wildfly

# Since you are interested in the 9.x branch, switch to that branch (master branch is 10.x)
git checkout 9.x

# Set JAVA_HOME to point to JDK 7 (9.x branch requires JDK 7 and master branch requires JDK 8)
export JAVA_HOME=..... path to my JDK 7 installation

# Run the build, skipping the tests (skipping tests is fine since the code  that is upstream compiles and runs fine and you haven't done any local changes)
# Make sure you have installed latest MAVEN and have "mvn" in your system PATH
mvn clean install -DskipTests=true

# After the build completes successfully, go to the dist dir where WildFly binary is extracted and available for use
cd dist/target/wildfly-9.0.0.CR2-SNAPSHOT/

That should be enough to build from source.

(You can copy over the wildfly-9.0.0.CR2-SNAPSHOT/ to any other location and start using it just like a downloaded binary)

If you want to verify the fix that's being reviewed and not yet in upstream, before it gets merged, then follow these additional steps:

# Go to the directory where you checked out wildfly earlier
cd <wildfly-checkout-dir>

# Add the repo which contains the proposed fix
git remote add jaikiran https://github.com/jaikiran/wildfly.git

# Fetch the remote repo locally
git fetch jaikiran

# Checkout to the branch containing the fix
git checkout jaikiran/wfly-4751

# rebase against latest 9.x branch of upstream repo
git rebase origin/9.x

# Now build the source containing this fix afresh
mvn clean install -DskipTests=true

# Upon successful completion of the build, go to dist/target/ where you have the WildFly runtime wildfly-9.0.0.CR2-SNAPSHOT/
cd dist/target/wildfly-9.0.0.CR2-SNAPSHOT/

[jewellgm]

Due to the processes here, I have to get approval to access the source repository directly.  Once I receive the approval, I'll build and perform the test.

[jewellgm]

Nothing is ever easy, unfortunately.  I received approval to get the WildFly source code, but our firewall is preventing the git client from accessing github.  As a result, I downloaded a zip file of the 9.x branch, and then manually applied that changes you made.  Building is failing, though, on the "Full Feature Pack" module.  Can you tell what's going on based on the following error messages?

[INFO] --- maven-enforcer-plugin:1.3.1:enforce (ban-transitive-deps) @ wildfly-f

eature-pack ---

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BanTransitiveDependencies fa

iled with message:

org.wildfly:wildfly-feature-pack:pom:9.0.0.CR2-SNAPSHOT

   org.wildfly:wildfly-client-all:jar:9.0.0.CR2-SNAPSHOT:compile has transitive

dependencies:

      org.jboss.remotingjmx:remoting-jmx:jar:2.0.1.Final:compile

         org.jboss.logging:jboss-logging:jar:3.2.1.Final:compile

         org.jboss.marshalling:jboss-marshalling:jar:1.4.10.Final:compile

         org.jboss.marshalling:jboss-marshalling-river:jar:1.4.10.Final:compile

         org.jboss.remoting:jboss-remoting:jar:4.0.9.Final:compile

         org.jboss.sasl:jboss-sasl:jar:1.0.5.Final:compile

         org.jboss.xnio:xnio-api:jar:3.3.1.Final:compile

         org.jboss.xnio:xnio-nio:jar:3.3.1.Final:compile

[INFO] ------------------------------------------------------------------------

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.

3.1:enforce (ban-transitive-deps) on project wildfly-feature-pack: Some Enforcer

rules have failed. Look above for specific messages explaining why the rule fai

led. -> [Help 1]

[jewellgm]

Found this issue:

https://issues.jboss.org/browse/WFLY-4534

Continuing as suggested.

[jewellgm]

Good news!  It appears that your fix has resolved my problem.  I have stopped and restarted things several times, and things are looking good.  I did have one instance where a topic lookup failed, but things may have been in a bad state on my box.  I'm going to keep testing things, and let you know whether I discover anything.

I saw in your notes on the pull request that there's an issue with your fix when there's a backup JMS server.  Do you anticipate that you'll be able to resolve this issue before CR2 is released?

[jaikiran]

Greg Jewell wrote:

Good news!  It appears that your fix has resolved my problem.  I have stopped and restarted things several times, and things are looking good. 

Glad to hear!

Greg Jewell wrote:

I saw in your notes on the pull request that there's an issue with your fix when there's a backup JMS server.  Do you anticipate that you'll be able to resolve this issue before CR2 is released?

I've updated the PR to fix that issue too and it's now passing. The messaging/WildFly team will review and then decide whether to merge it in. Either way, I believe it will be decided before CR2 is released.

[jewellgm]

Greg Jewell wrote:

I saw in your notes on the pull request that there's an issue with your fix when there's a backup JMS server.  Do you anticipate that you'll be able to resolve this issue before CR2 is released?

I've updated the PR to fix that issue too and it's now passing. The messaging/WildFly team will review and then decide whether to merge it in. Either way, I believe it will be decided before CR2 is released.

I'll keep an eye on it and verify that the fix goes into CR2.  Assuming that your fix does make it into the final WF9 release, I'll mark this thread as resolved.  Thank you again for your help!

[jaikiran]

9.0.0.CR2 has been released today Announcement: WildFly 9.0.2.Final released and that one has the fix for this. Please download and give it a try.

[jewellgm]

jaikiran pai wrote:

9.0.0.CR2 has been released today Announcement: WildFly 9.0.0.CR2 released and that one has the fix for this. Please download and give it a try.

I'm not in the office today, but I'll download it on Monday.

[jewellgm]

I just tested things out with CR2, and the lookups seem to be working properly.  Thank you again!