3 Replies Latest reply on Jul 28, 2015 2:10 PM by jesper.pedersen

JBJCA-1276

dpospisil Jul 28, 2015 12:27 PM

I have created PR for fixing JBJCA-1276 - Prefill race condition in flush

Could anyone help me to indicate what is wrong with the PR?

Many thanks,

- Dominik

1. Re: JBJCA-1276

jesper.pedersen Jul 28, 2015 1:16 PM (in response to dpospisil)

Prefill is a combination of things - you have the PrefillPool check and the min-pool-size check. However you are missing the ironjacamar/AbstractPrefillPool.java at 1.0 · ironjacamar/ironjacamar · GitHub checks atm.

HTH
Actions
2. Re: JBJCA-1276

dpospisil Jul 28, 2015 1:44 PM (in response to jesper.pedersen)

Hmm, I do not see this checked in
ironjacamar/AbstractPool.java at 1.2 · ironjacamar/ironjacamar · GitHub

seems that 1.2 calls isPrefill() which does getPoolConfiguration().getMinSize() > 0 and ignores strictMin as well.

Does that mean that it is broken in 1.2 as well?
Actions
3. Re: JBJCA-1276

jesper.pedersen Jul 28, 2015 2:10 PM (in response to dpospisil)

Prefill in 1.2 is guarded by the method call plus the local variable - in 1.0 to have to combined those checks. Flushing is different in 1.2, and there are additional checks in the ManagedConnectionPool implementation around this.
Actions