8 Replies Latest reply on Sep 15, 2015 7:34 AM by vpenugo

rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

vpenugo Sep 8, 2015 7:17 AM

Hi,

I have a popupPanel where I am using this in many pages. So, I included the popup in main page with <ui:include src="popupsearch.xhtml"/> tag. In the popup we have <h:form> and <rich:extendedDataTable> finally I have a a4j command button to close the popup. but when we open the main page by default it is showing the a4j command button ( last component in my popup xhtml ). it is working fine in Richfaces 3.3.3. I am seeing this behavior after upgraded to Richfaces 4.3.

Can any one faced this issue or anyone know why popupPanel is behaving like this. Please suggest me some solution for this.

1. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

michpetrov Sep 8, 2015 8:12 AM (in response to vpenugo)

Can you show the code of the popupPanel?
Actions
2. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

vpenugo Sep 8, 2015 8:39 AM (in response to michpetrov)

Below is the Popup code.

popupsearch.xhtml

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
          "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
    xmlns:ui="http://java.sun.com/jsf/facelets"
    xmlns:h="http://java.sun.com/jsf/html"
    xmlns:f="http://java.sun.com/jsf/core"
    xmlns:a4j="http://richfaces.org/a4j"
    xmlns:rich="http://richfaces.org/rich">

<rich:popupPanel id="memberPopupPanel" autosized="true" modal="true" width="1165" >

<h:form id="memberPopupForm">

     here I have some panel grids to arrange input boxes and datatable and command buttons.

</h:form>
</rich:popupPanel>
</html>

Mainpage.xhtml <where I included popup page>

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
          "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:ui="http://java.sun.com/jsf/facelets"
      xmlns:h="http://java.sun.com/jsf/html"
      xmlns:f="http://java.sun.com/jsf/core"
      xmlns:a4j="http://richfaces.org/a4j"
      xmlns:rich="http://richfaces.org/rich"
      xmlns:c="http://java.sun.com/jstl/core">

<ui:composition template="/layout/layout.xhtml">
    <ui:define name="content">
     <h:form id="mainform">
                        <rich:tabPanel switchType="server" id="tab" activeItem="#{Bean.tabName}"
                            tabHeaderClass="maintabHeader" tabContentClass="mainTab"
                            tabActiveHeaderClass="selectedtabHeader" tabInactiveHeaderClass="unSelectedtabHeader">
                         <rich:tab header="#{msg['menu.reports']}" styleClass="textColorMenu" name="reportTab"
                                action="#{Bean.renderSoloPage}">
                                <h:panelGrid id="reportWrapPG" rendered="#{Bean.tabName=='TabName'}" width="100%">
                                    <h:graphicImage value="/images/spacer.gif" id="switchSpacer01" height="20"/>
                                    <ui:include src="popupsearch.xhtml"/>
                                    <ui:include src="#{Bean.TabContent}"/>
                                </h:panelGrid>
                            </rich:tab>

                     </rich:tabPanel>
       </h:form>
</ui:define>
</ui:composition>
</html>
Actions
3. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

michpetrov Sep 8, 2015 9:26 AM (in response to vpenugo)

You need to remove the nested forms, although I don't think that's the issue. You can debug the JavaScript - the "show" method in popupPanel.js opens the panel, check if it's being called.
Actions
4. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

vpenugo Sep 9, 2015 5:43 AM (in response to michpetrov)

Hi Michal, Thank you for your response. I removed nested forms and still same behavior. Today I did some research on this and I found that, if you have 'ExtendedDataTable' in the popup it is behaving like this. we have a extended datatable in popup to show the search results. but, I am curious to know if any issue with the popups having ExtendedDataTable in Richfaces 4.x. If I use normal rich:datatable, everything looks good. but my requirement is use ExtendedDataTable here.
Actions
5. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

michpetrov Sep 9, 2015 7:53 AM (in response to vpenugo)

There is a method that makes the table's parent visible if it isn't but that shouldn't happen inside the popupPanel (and the parent should be hidden again even if it did). It's possible there was a bug, I don't see any issues in RichFaces 4.5.
Actions
6. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

vpenugo Sep 10, 2015 3:47 AM (in response to michpetrov)

I have upgraded the RF to 4.5.0 and issue is still persists. still it is showing popup content ( content after <rich:extendedDataTable> tag in popup ) in included page. I am really frustrating with this.
Actions
7. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

michpetrov Sep 10, 2015 4:06 AM (in response to vpenugo)

Can you create a reproducer? (http://sscce.org)
Actions
8. Re: rich:popupPanel content showing without calling show() after Richfaces migration from 3.3.3 to 4.3

vpenugo Sep 15, 2015 7:34 AM (in response to vpenugo)

After I did some research, I am able to resolve this issue. issue here is in my rich:extendedDataTable we have a column group with header columns and we have columns for to write the data. if we add data columns with header facets this issue is not coming.. I am not sure why this causing the issue in RF 4.x. anyway now problem solved and I am able to continue my upgrade from RF 3.3.3 to RF 4.5.6.

Thanks Michal, for all your responses.
Actions

Go to original post