Requirements for ordering RecoveryModules

[mmusgrov]

gytis came across an issue where the REST-AT -> JTA bridge recovery is failing. He found the root cause to be that the XARecoveryModule is recovering the bridge before the InboundBridgeRecoveryModule gets a chance to run. We had a similar issue with the CMR functionality where the CommitMarkableResourceRecordRecoveryModule had to run before the AtomicActionRecoveryModule tried to recover it and the fix we applied there was to hard code the order via the WildFly subsystem (see ArjunaRecoveryManagerService). Since we now have two examples where the ordering is an issue I think it is time we added an interface for ordering RecoveryModules.

[mmusgrov]

Note that we can already create an ordering in standalone mode using a jbossts properties file by setting the RecoveryEnvironmentBean.recoveryModuleClassNames property. However, this will not work when running inside a wildfly subsystem.

Also noteworthy is that if the REST-AT bridge RM can move the record during periodicWorkFirstPass then any other RM will not see it during periodicWorkSecondPass and simply ignore it. If that fix works for the bridge then I don't think it is worthwhile adding a RecoveryModule ordering interface for the single CMR use case.

[tomjenkinson]

I was about to respond that the order is defined by the enlistment order so either via Java code or via the order in JBossTS properties file. I would not be against supporting some kind of ordering interface. Perhaps it could be a new interface that has something like "RecoveryModule[] getMustRunAfter()" and a second one "RecoveryModule[] getMustRunBefore()".

What was the issue number for the problem that gytis came across?

[mmusgrov]

It happened with the bridge ([JBTM-2544] RTS inbound bridge recovery does not work with JTS - JBoss Issue Tracker).

[mmusgrov]

We can configure the order using a properties file or by setting a system property.