ServletContext getResourceAsStream broken with latest Wildfly 10.0.0.CR5

[alban5650]

Hi,

I hope someone can help.

We have a legacy application that is using struts 1. The application has been running fine from Jboss 3.2.x to the previous Wildfly 10.0.0 CR4 including EAP 4 / 5 and 6 releases.

However something has changed in the latest Wildfly 10 CR5 release. The default ActionServlet fails to initialize. Looking at the struts 1.3.10 source code, the servlet fails to read the /WEB-INF/web.xml throwing the following exception:

12:22:24,722 ERROR [org.apache.struts.action.ActionServlet] (ServerService Thread Pool -- 100) Unable to initialize Struts ActionServlet due to an unexpected exception or error thrown, so marking the servlet as unavailable.  Most likely, this is due to an incorrect or missing library dependency.: javax.servlet.ServletException: The /WEB-INF/web.xml was not found.

    at org.apache.struts.action.ActionServlet.initServlet(ActionServlet.java:1781)

    at org.apache.struts.action.ActionServlet.init(ActionServlet.java:349)

    at javax.servlet.GenericServlet.init(GenericServlet.java:244)

ActionServlet.java source code - line 1781:

InputStream input =
     getServletContext().getResourceAsStream("/WEB-INF/web.xml");
if (input == null) {
     log.error(internal.getMessage("configWebXml"));
     throw new ServletException(internal.getMessage("configWebXml"));
}

The web application is packaged inside an exploded ear file with the following simplified structure:

     myAppp.ear (exploded)

          |--- myEjbs.jar

          |--- myWebApp.war (exploded)

          |          |--- WEB-INF

          |                    |-- web.xml

          |                    |--- lib

          |                           |--- struts.jar

          |--- META-INF

                    |--- application.xml

The application.xml contains the following modules:

<module>
  <ejb>myEjbs.jar</ejb>
</module>
<module>
  <web>
    <web-uri>myWebApp.war</web-uri>
    <context-root>myWebApp</context-root> 
  </web>
</module>

This seems to be a bug to me unless there are new configuration changes required in this latest release to allow a servlet accessing a resource?

Thanks in advance,

Alban

[jaikiran]

It does look like  a bug. Can you file a WFLY JIRA Agile Board - JBoss Issue Tracker so that someone can look into it?

[alban5650]

Thanks Jaikiran,

I created a new JIRA for this: https://issues.jboss.org/browse/WFLY-5918

[ctomc]

Can you please share simple reproducer?

As I cannot reproduce this just with info you provided.

I tried with "hello world" struts 1 example using struts 1.3.10 and I cannot reproduce this.

[ctomc]

Manged to reproduce your problem.

It is caused by mistakenly starting server with wrong case.

if you would start server from bin directory and run standalone.bat it would probably work just fine.

[alban5650]

Hi Tomaz,

What do you mean starting the server with the wrong case?

I start my wildfly instance using jbosstools in eclipse.

My wildfly directory structure is configured the following way:

D:

|-- wildfly

        |-- wildfly-10.0.0 (ju)

        |-- wildfly-10.0.0.CR4

        |-- wildfly-10.0.0.CR5

The 'wildfly-10.0.0' is a windows junction (similar to a symbolic link in linux) that points to the various pre-release of wildfly 10 like early Beta and CR releases. This allows me to just create that link without having to set my deployment properties and recreate my wildfly runtime in eclipse. This worked pretty well until this CR5 release :-(

I checked the path and everything looks fine case(sensitivity)-wise.

I had tried to start using command prompt from the wildfly-10.0.0\bin but was getting the same exception. I then specifically started using the actual wildfly-10.0.0.CR5\bin directory and then the server started up fine.

I've seen the JIRA update and will try to see how I can test the patch (need to get familiar with git and applying patches first when I find few minutes).

And many thanks for the investigation.

[alban5650]

I managed to test the change provided in the JIRA and can confirm that this issue is now fixed.

Thanks again

[ctomc]

junctions, yey

well that is something you should mention first

junctions are bit different than linux symlinks. Mostly have lots of issues...

Check if you created the junction properly case wise.

[alban5650]

Yes junctions. I have been using those for ages and never had any issues with it before (already used with early JBoss 7 and EAP6). So I wasn't suspecting this to be the issue. :-(

The case seems fine with me and the only thing I did to switch back and forth between CR4 and CR5 was:

junction -d wildfly-10.0.0 (to delete junction with CR4)

junction wildfly-10.0.0 wildfly-10.0.0.CR5

>> fail to start Wildfly

junction -d wildfly-10.0.0

junction wildfly-10.0.0 wildfly-10.0.0.CR4

>> Wildfly starts fine

Anyway, hopefully the patch will make it to Wildfly 10 final as well as EAP 7.

[ctomc]

Just tested the fix also with junctions and it works fine.

The PR with change was already merged to master and will definitely be part of WildFly 10 Final

just bit of background java's java.io.File and java.nio.Path behave bit differently around junctions which is why this occurred.